Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: extensions/renderer/resources/guest_view/guest_view_iframe.js

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: address comments from nasko@ + git cl format Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/guest_view_iframe.js
diff --git a/extensions/renderer/resources/guest_view/guest_view_iframe.js b/extensions/renderer/resources/guest_view/guest_view_iframe.js
index c27c809e299687294c268151eb51d3e467acf513..dba1b9136f1b8535e8087bc392d70e03d9f07d5e 100644
--- a/extensions/renderer/resources/guest_view/guest_view_iframe.js
+++ b/extensions/renderer/resources/guest_view/guest_view_iframe.js
@@ -49,8 +49,10 @@ GuestViewImpl.prototype.attachImpl$ = function(
attachParams['instanceId'] = viewInstanceId;
var contentWindow = getIframeContentWindow(viewInstanceId);
- // TODO(lazyboy): Call binding function to attach this guest.
- // |contentWindow| should be used to retrieve the RenderFrame in cpp.
+ // |contentWindow| is used to retrieve the RenderFrame in cpp.
+ GuestViewInternalNatives.AttachIframeGuest(
+ internalInstanceId, this.id, attachParams, contentWindow,
+ callbackWrapper.bind(this, callback));
this.internalInstanceId = internalInstanceId;
this.state = GuestViewImpl.GuestState.GUEST_STATE_ATTACHED;

Powered by Google App Engine
This is Rietveld 408576698