extensions/renderer/guest_view/guest_view_internal_custom_bindings.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: address comments from nasko@ + git cl format Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « extensions/renderer/guest_view/extensions_iframe_guest_view_request.cc ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

index 6a6d6c305321cb2816c97222316fe3cad4e3b15c..f18e15cd7ab232b00b66be9fe240b88a2397ac6f 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

@@ -47,6 +47,13 @@ class GuestViewInternalCustomBindings : public ObjectBackedNativeHandler {

// been detached.

void DetachGuest(const v8::FunctionCallbackInfo<v8::Value>& args);

+ // AttachIframeGuest is --site-per-process variant of AttachGuest().

+ //

+ // AttachIframeGuest takes a |contentWindow| parameter in addition to the

+ // parameters to AttachGuest. That parameter is used to identify the

+ // RenderFrame of the <iframe> container element.

+ void AttachIframeGuest(const v8::FunctionCallbackInfo<v8::Value>& args);

// GetContentWindow takes in a RenderView routing ID and returns the

// Window JavaScript object for that RenderView.

void GetContentWindow(const v8::FunctionCallbackInfo<v8::Value>& args);