Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: content/public/browser/web_contents.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: Make <webview> work without --site-per-process as well Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 43804129322c4ed56ffc7b451c6ae1e5b84bfc2d..08920a59de204c700fcead3b15b67eb1eb251ab9 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -156,6 +156,14 @@ class WebContents : public PageNavigator,
~WebContents() override {}
+ // Attaches or associates this WebContents to a frame in
Charlie Reis 2015/04/30 23:06:47 this guest WebContents to its embedder frame in...
lazyboy 2015/05/05 07:28:15 Done.
+ // |embedder_web_contents|.
+ // The frame can identified by
+ // {embedder_frame_process_id, embedder_frame_routing_id} pair.
Charlie Reis 2015/04/30 23:06:47 Also say what this returns.
lazyboy 2015/05/05 07:28:15 Done.
+ virtual int AttachLocalFrameToGuest(WebContents* embedder_web_contents,
Charlie Reis 2015/04/30 23:06:47 This name doesn't make sense to me, if we're calli
lazyboy 2015/05/05 07:28:15 Ok.
+ int embedder_frame_process_id,
+ int embedder_frame_routing_id) = 0;
Charlie Reis 2015/04/30 23:06:47 I think it might be clearer to pass in the the Ren
lazyboy 2015/05/05 07:28:15 Done.
+
// Intrinsic tab state -------------------------------------------------------
// Gets/Sets the delegate.

Powered by Google App Engine
This is Rietveld 408576698