content/renderer/render_view_impl.cc - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: Revert unused changes from previous attempt + more cleanup. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/frame_messages.h ('K') | « content/renderer/render_frame_proxy.cc ('k') | extensions/browser/guest_view/guest_view_base.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 465329feed1466f89f5ca4dd947b51d959e68d40..c0bb42eade074c137fe4c5037d795b7f56410905 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -753,6 +753,9 @@ void RenderViewImpl::Initialize(const ViewMsg_New_Params& params,

main_render_frame_->set_render_frame_proxy(proxy);

}

+ // This breaks postMessage otherwise.

+ webview()->setMainFrame(main_render_frame_->GetWebFrame());

Fady Samuel 2015/03/04 22:21:06 What does this do?

+ /*

// In --site-per-process, just use the WebRemoteFrame as the main frame.

if (command_line.HasSwitch(switches::kSitePerProcess) && proxy) {

webview()->setMainFrame(proxy->web_frame());

@@ -762,6 +765,7 @@ void RenderViewImpl::Initialize(const ViewMsg_New_Params& params,

} else {

webview()->setMainFrame(main_render_frame_->GetWebFrame());

}

+ */

main_render_frame_->Initialize();

if (switches::IsTouchDragDropEnabled())