content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: Revert unused changes from previous attempt + more cleanup. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_proxy_host.cc ('K') | « content/browser/frame_host/render_frame_proxy_host.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index ebbea17c2a927c70d7ad24f782b1946d61e31fdc..acb87245426edbb6d36dc3dae58474d6c19c85f5 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -123,7 +123,7 @@ void RenderWidgetHostViewChildFrame::ImeCancelComposition() {

void RenderWidgetHostViewChildFrame::ImeCompositionRangeChanged(

const gfx::Range& range,

const std::vector<gfx::Rect>& character_bounds) {

- NOTREACHED();

Fady Samuel 2015/03/04 22:21:06 Does this mean IME is broken?

+// NOTREACHED();

}

void RenderWidgetHostViewChildFrame::MovePluginWindows(

@@ -137,7 +137,7 @@ void RenderWidgetHostViewChildFrame::UpdateCursor(const WebCursor& cursor) {

}

void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) {

- NOTREACHED();

+// NOTREACHED();

}

void RenderWidgetHostViewChildFrame::TextInputTypeChanged(