components/guest_view/renderer/iframe_guest_view_container.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/guest_view/renderer/iframe_guest_view_container.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: Address comments move destruction callback to GuestViewContainer Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/guest_view/browser/guest_view_message_filter.cc ('K') | « components/guest_view/renderer/guest_view_container.cc ('k') | components/guest_view/renderer/iframe_guest_view_container.cc » ('j') | components/guest_view/renderer/iframe_guest_view_request.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_GUEST_VIEW_RENDERER_IFRAME_GUEST_VIEW_CONTAINER_H_

	6 #define COMPONENTS_GUEST_VIEW_RENDERER_IFRAME_GUEST_VIEW_CONTAINER_H_

	7

	8 #include "components/guest_view/renderer/guest_view_container.h"

	9

	10 namespace guest_view {

	11

	12 class IframeGuestViewContainer : public GuestViewContainer {
	Fady Samuel 2015/06/24 22:01:10 nit: Description of this class and what it does th nit: Description of this class and what it does that's unique to iframes. lazyboy 2015/06/24 23:01:51 Done. Show quoted text On 2015/06/24 22:01:10, Fady Samuel wrote: > nit: Description of this class and what it does that's unique to iframes. Done.
	13 public:

	14 explicit IframeGuestViewContainer(content::RenderFrame* render_frame);

	15 ~IframeGuestViewContainer() override;

	16

	17 // GuestViewContainer overrides.

	18 bool OnMessage(const IPC::Message& message) override;

	19

	20 private:

	21 DISALLOW_COPY_AND_ASSIGN(IframeGuestViewContainer);

	22 };

	23

	24 } // namespace guest_view

	25

	26 #endif // COMPONENTS_GUEST_VIEW_RENDERER_IFRAME_GUEST_VIEW_CONTAINER_H_

OLD	NEW