Make <webview> use out-of-process iframe architecture.

extensions/browser/guest_view/extensions_guest_view_message_filter.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/extensions_guest_view_message_filter.h"
 
 #include "components/guest_view/browser/guest_view_base.h"
 #include "components/guest_view/browser/guest_view_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_frame_host.h"
@@ skipping 30 matching lines @@
                              context) {}
 
 ExtensionsGuestViewMessageFilter::~ExtensionsGuestViewMessageFilter() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 }
 
 void ExtensionsGuestViewMessageFilter::OverrideThreadForMessage(
     const IPC::Message& message,
     BrowserThread::ID* thread) {
   switch (message.type()) {
+    case ExtensionsGuestViewHostMsg_AttachToEmbedderFrame::ID:
     case ExtensionsGuestViewHostMsg_CreateMimeHandlerViewGuest::ID:
     case ExtensionsGuestViewHostMsg_ResizeGuest::ID:
       *thread = BrowserThread::UI;
       break;
     default:
       GuestViewMessageFilter::OverrideThreadForMessage(message, thread);
   }
 }
 
 bool ExtensionsGuestViewMessageFilter::OnMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ExtensionsGuestViewMessageFilter, message)
+  IPC_MESSAGE_HANDLER(ExtensionsGuestViewHostMsg_AttachToEmbedderFrame,
+                      OnAttachToEmbedderFrame)
     IPC_MESSAGE_HANDLER(ExtensionsGuestViewHostMsg_CanExecuteContentScriptSync,
                         OnCanExecuteContentScript)
     IPC_MESSAGE_HANDLER(ExtensionsGuestViewHostMsg_CreateMimeHandlerViewGuest,
                         OnCreateMimeHandlerViewGuest)
     IPC_MESSAGE_HANDLER(ExtensionsGuestViewHostMsg_ResizeGuest, OnResizeGuest)
     IPC_MESSAGE_UNHANDLED(
         handled = GuestViewMessageFilter::OnMessageReceived(message))
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 GuestViewManager* ExtensionsGuestViewMessageFilter::
     GetOrCreateGuestViewManager() {
   auto manager = GuestViewManager::FromBrowserContext(browser_context_);
   if (!manager) {
     manager = GuestViewManager::CreateWithDelegate(
         browser_context_,
         scoped_ptr<GuestViewManagerDelegate>(
             new ExtensionsGuestViewManagerDelegate(browser_context_)));
   }
   return manager;
 }
 
+void ExtensionsGuestViewMessageFilter::OnAttachToEmbedderFrame(
+    int embedder_local_render_frame_id,
+    int element_instance_id,
+    int guest_instance_id,
+    const base::DictionaryValue& params) {
+  auto* manager = GuestViewManager::FromBrowserContext(browser_context_);
+  DCHECK(manager);
+  content::WebContents* guest_web_contents =
+      manager->GetGuestByInstanceIDSafely(guest_instance_id,
+                                          render_process_id_);
+  DCHECK(guest_web_contents);
+  auto* guest = WebViewGuest::FromWebContents(guest_web_contents);

[Fady Samuel, 2015/06/18 04:47:07]

Why do this for WebViewGuest  and not GuestViewBase?

Also, why is this code in extensions? This seems like it applies to all
GuestView types. It seems like this could be in components...

[lazyboy, 2015/06/22 19:43:20]

Done.

+  DCHECK(guest);
+  content::WebContents* owner_web_contents = guest->owner_web_contents();
+  DCHECK(owner_web_contents);
+  auto* embedder_frame = RenderFrameHost::FromID(
+      render_process_id_, embedder_local_render_frame_id);
+  guest_web_contents->AttachToOuterWebContentsFrame(owner_web_contents,
+                                                    embedder_frame);
+
+  manager->AttachGuest(render_process_id_, element_instance_id,
+                       guest_instance_id, params);
+
+  owner_web_contents->GetMainFrame()->Send(
+      new ExtensionsGuestViewMsg_AttachToEmbedderFrame_ACK(
+          element_instance_id));
+
+  guest->WillAttach(
+      owner_web_contents, element_instance_id, false,
+      base::Bind(&ExtensionsGuestViewMessageFilter::WillAttachCallback, this,
+                 guest));
+}
+
+void ExtensionsGuestViewMessageFilter::WillAttachCallback(
+    extensions::WebViewGuest* guest) {
+  guest->DidAttach(MSG_ROUTING_NONE);
+}
+
 void ExtensionsGuestViewMessageFilter::OnCanExecuteContentScript(
     int render_view_id,
     int script_id,
     bool* allowed) {
   WebViewRendererState::WebViewInfo info;
   WebViewRendererState::GetInstance()->GetInfo(render_process_id_,
                                                render_view_id, &info);
 
   *allowed =
       info.content_script_ids.find(script_id) != info.content_script_ids.end();
@@ skipping 79 matching lines @@
                        element_instance_id,
                        guest_instance_id,
                        attach_params);
 
   rfh->Send(
       new ExtensionsGuestViewMsg_CreateMimeHandlerViewGuestACK(
           element_instance_id));
 }
 
 }  // namespace extensions