Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: content/browser/frame_host/frame_tree_node.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: address comments from nasko@ + git cl format Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 25 matching lines...) Expand all
36 // Invoked when a FrameTreeNode is being destroyed. 36 // Invoked when a FrameTreeNode is being destroyed.
37 virtual void OnFrameTreeNodeDestroyed(FrameTreeNode* node) {} 37 virtual void OnFrameTreeNodeDestroyed(FrameTreeNode* node) {}
38 38
39 virtual ~Observer() {} 39 virtual ~Observer() {}
40 }; 40 };
41 41
42 // Returns the FrameTreeNode with the given global |frame_tree_node_id|, 42 // Returns the FrameTreeNode with the given global |frame_tree_node_id|,
43 // regardless of which FrameTree it is in. 43 // regardless of which FrameTree it is in.
44 static FrameTreeNode* GloballyFindByID(int frame_tree_node_id); 44 static FrameTreeNode* GloballyFindByID(int frame_tree_node_id);
45 45
46 static const int kFrameTreeNodeInvalidID = -1;
Charlie Reis 2015/06/18 00:13:18 nit: This should go above static methods.
lazyboy 2015/06/18 22:45:12 Done.
47
46 FrameTreeNode(FrameTree* frame_tree, 48 FrameTreeNode(FrameTree* frame_tree,
47 Navigator* navigator, 49 Navigator* navigator,
48 RenderFrameHostDelegate* render_frame_delegate, 50 RenderFrameHostDelegate* render_frame_delegate,
49 RenderViewHostDelegate* render_view_delegate, 51 RenderViewHostDelegate* render_view_delegate,
50 RenderWidgetHostDelegate* render_widget_delegate, 52 RenderWidgetHostDelegate* render_widget_delegate,
51 RenderFrameHostManager::Delegate* manager_delegate, 53 RenderFrameHostManager::Delegate* manager_delegate,
52 blink::WebTreeScopeType scope, 54 blink::WebTreeScopeType scope,
53 const std::string& name, 55 const std::string& name,
54 blink::WebSandboxFlags sandbox_flags); 56 blink::WebSandboxFlags sandbox_flags);
55 57
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 266
265 // List of objects observing this FrameTreeNode. 267 // List of objects observing this FrameTreeNode.
266 base::ObserverList<Observer> observers_; 268 base::ObserverList<Observer> observers_;
267 269
268 DISALLOW_COPY_AND_ASSIGN(FrameTreeNode); 270 DISALLOW_COPY_AND_ASSIGN(FrameTreeNode);
269 }; 271 };
270 272
271 } // namespace content 273 } // namespace content
272 274
273 #endif // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_ 275 #endif // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698