Make <webview> use out-of-process iframe architecture.

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/json/json_reader.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/sys_info.h"
 #include "base/time/time.h"
 #include "base/trace_event/trace_event.h"
 #include "base/values.h"
 #include "cc/base/switches.h"
 #include "content/browser/bad_message.h"
+#include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/browser/gpu/gpu_process_host.h"
 #include "content/browser/gpu/gpu_surface_tracker.h"
 #include "content/browser/host_zoom_map_impl.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/renderer_host/dip_util.h"
@@ skipping 259 matching lines @@
 
   GpuSurfaceTracker::Get()->SetSurfaceHandle(
       surface_id(), GetCompositingSurface());
 
   // Ensure the RenderView starts with a next_page_id larger than any existing
   // page ID it might be asked to render.
   int32 next_page_id = 1;
   if (max_page_id > -1)
     next_page_id = max_page_id + 1;
 
+  int proxy_route_id_to_send = proxy_route_id;
+
+  // Do not instruct the view to create a proxy if this is a swapped out

[nasko, 2015/06/15 23:00:13]

I'm trying to kill "swapped out", so let's not add any more usages of it : ). It
doesn't bring much additional meaning to the sentence that wouldn't exist
without it and there isn't actually any check based on the swapped out state of
the RenderViewHost.

[lazyboy, 2015/06/16 17:59:51]

Good point.
This code path is unused as we do not create RenderViewHost anymore
after switching from RFHM::CreateRenderFrameProxy() to
"new RenderFrameProxyHost()"... in RFHM::CreateOuterDelegateProxy().
So all of this can go away now.
Does this sound right?

+  // RenderView for an inner WebContents.
+  // The proxy will be created using RFHM::SwapFrameWithProxy().

[nasko, 2015/06/15 23:00:13]

There is no SwapFrameWithProxy method anymore.

[lazyboy, 2015/06/16 17:59:51]

See above ^^^.

+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kSitePerProcess) &&
+      BrowserPluginGuest::IsGuest(this)) {
+    proxy_route_id_to_send = MSG_ROUTING_NONE;
+  }
+
   ViewMsg_New_Params params;
   params.renderer_preferences =
       delegate_->GetRendererPrefs(GetProcess()->GetBrowserContext());
 #if defined(OS_WIN)
   GetWindowsSpecificPrefs(&params.renderer_preferences);
 #endif
   params.web_preferences = GetWebkitPreferences();
   params.view_id = GetRoutingID();
   params.main_frame_routing_id = main_frame_routing_id_;
   params.surface_id = surface_id();
   params.session_storage_namespace_id =
       delegate_->GetSessionStorageNamespace(instance_.get())->id();
   params.frame_name = frame_name;
   // Ensure the RenderView sets its opener correctly.
   params.opener_route_id = opener_route_id;
   params.swapped_out = !is_active_;
   params.replicated_frame_state = replicated_frame_state;
-  params.proxy_routing_id = proxy_route_id;
+  params.proxy_routing_id = proxy_route_id_to_send;
   params.hidden = is_hidden();
   params.never_visible = delegate_->IsNeverVisible();
   params.window_was_created_with_opener = window_was_created_with_opener;
   params.next_page_id = next_page_id;
   params.enable_auto_resize = auto_resize_enabled();
   params.min_size = min_size_for_auto_resize();
   params.max_size = max_size_for_auto_resize();
   GetResizeParams(&params.initial_size);
 
   if (!Send(new ViewMsg_New(params)))
@@ skipping 1093 matching lines @@
     if (!policy->CanReadFile(GetProcess()->GetID(), file))
       policy->GrantReadFile(GetProcess()->GetID(), file);
   }
 }
 
 void RenderViewHostImpl::SelectWordAroundCaret() {
   Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID()));
 }
 
 }  // namespace content