Make <webview> use out-of-process iframe architecture.

content/browser/frame_host/render_widget_host_view_child_frame.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 
 #include "content/browser/accessibility/browser_accessibility_manager.h"
+#include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/frame_host/cross_process_frame_connector.h"
+#include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/render_process_host.h"
 
 namespace content {
 
 RenderWidgetHostViewChildFrame::RenderWidgetHostViewChildFrame(
     RenderWidgetHost* widget_host)
     : host_(RenderWidgetHostImpl::From(widget_host)),
@@ skipping 108 matching lines @@
 }
 
 void RenderWidgetHostViewChildFrame::MovePluginWindows(
     const std::vector<WebPluginGeometry>& moves) {
 }
 
 void RenderWidgetHostViewChildFrame::UpdateCursor(const WebCursor& cursor) {
 }
 
 void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) {
-  NOTREACHED();
+  if (!BrowserPluginGuest::IsGuest(static_cast<RenderViewHostImpl*>(

[Charlie Reis, 2015/05/22 23:44:31]

This needs a comment.  I'm also confused, since it seems backwards.  Won't
IsGuest be true in the default <webview> flow, causing us to skip the
NOTREACHED?  And is it false in --site-per-process, in which case we hit the
NOTREACHED?  What was the intention?

[lazyboy, 2015/05/26 16:32:54]

default webview does not hit this function.
I think is_loading is broken in this CL as you've pointed
out in the Swap IPC.

+          RenderViewHost::From(host_)))) {
+    NOTREACHED();
+  }
 }
 
 void RenderWidgetHostViewChildFrame::TextInputTypeChanged(
     ui::TextInputType type,
     ui::TextInputMode input_mode,
     bool can_compose_inline,
     int flags) {
   // TODO(kenrb): Implement.
 }
 
@@ skipping 154 matching lines @@
 #endif // defined(OS_WIN)
 
 BrowserAccessibilityManager*
 RenderWidgetHostViewChildFrame::CreateBrowserAccessibilityManager(
     BrowserAccessibilityDelegate* delegate) {
   return BrowserAccessibilityManager::Create(
       BrowserAccessibilityManager::GetEmptyDocument(), delegate);
 }
 
 }  // namespace content