Make <webview> use out-of-process iframe architecture.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 984 matching lines @@
   while ((observer = it.GetNext()) != NULL) {
     if (observer->OnMessageReceived(msg))
       return true;
   }
 
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(RenderFrameImpl, msg)
     IPC_MESSAGE_HANDLER(FrameMsg_Navigate, OnNavigate)
     IPC_MESSAGE_HANDLER(FrameMsg_BeforeUnload, OnBeforeUnload)
     IPC_MESSAGE_HANDLER(FrameMsg_SwapOut, OnSwapOut)
+    IPC_MESSAGE_HANDLER(FrameMsg_ReplaceLocalFrameWithProxy,
+                        OnReplaceLocalFrameWithProxy)
     IPC_MESSAGE_HANDLER(FrameMsg_Stop, OnStop)
     IPC_MESSAGE_HANDLER(FrameMsg_ContextMenuClosed, OnContextMenuClosed)
     IPC_MESSAGE_HANDLER(FrameMsg_CustomContextMenuAction,
                         OnCustomContextMenuAction)
     IPC_MESSAGE_HANDLER(InputMsg_Undo, OnUndo)
     IPC_MESSAGE_HANDLER(InputMsg_Redo, OnRedo)
     IPC_MESSAGE_HANDLER(InputMsg_Cut, OnCut)
     IPC_MESSAGE_HANDLER(InputMsg_Copy, OnCopy)
     IPC_MESSAGE_HANDLER(InputMsg_Paste, OnPaste)
     IPC_MESSAGE_HANDLER(InputMsg_PasteAndMatchStyle, OnPasteAndMatchStyle)
@@ skipping 328 matching lines @@
   // When we do an unconditional swap for all frames, we can remove
   // !is_main_frame below.
   if (is_site_per_process && proxy && !is_main_frame)
     proxy->SetReplicatedState(replicated_frame_state);
 
   // Safe to exit if no one else is using the process.
   if (is_main_frame)
     render_view_->WasSwappedOut();
 }
 
+void RenderFrameImpl::OnReplaceLocalFrameWithProxy(int proxy_routing_id) {
+  RenderFrameProxy* proxy_to_replace_frame = RenderFrameProxy::FromRoutingID(
+      proxy_routing_id);
+  DCHECK(proxy_to_replace_frame);
+
+  blink::WebRemoteFrame* web_frame =
+      blink::WebRemoteFrame::create(proxy_to_replace_frame);

[Charlie Reis, 2015/04/30 23:06:47]

It's not obvious why the existing proxy and swap codepaths aren't sufficient for
this, and it makes me nervous to add another path that we have to reason about.

Can you check with Daniel and Lucas about this?  They've been working on the
swap semantics and would know whether there's a better way to handle this.  (If
there is a good reason for the separate path, we should have comments explaining
it.)

[lazyboy, 2015/05/05 07:28:15]

Using OnSwapOut() now.
Lucas and I checked this bit, so this function is removed.

+  proxy_to_replace_frame->SetWebRemoteFrame(web_frame);
+  proxy_to_replace_frame->web_frame()->initializeFromFrame(frame_);
+  frame_->swap(proxy_to_replace_frame->web_frame());
+  render_view_->RegisterRenderFrameProxy(proxy_to_replace_frame);
+}
+
 void RenderFrameImpl::OnContextMenuClosed(
     const CustomContextMenuContext& custom_context) {
   if (custom_context.request_id) {
     // External request, should be in our map.
     ContextMenuClient* client =
         pending_context_menus_.Lookup(custom_context.request_id);
     if (client) {
       client->OnMenuClosed(custom_context.request_id);
       pending_context_menus_.Remove(custom_context.request_id);
     }
@@ skipping 3508 matching lines @@
 #elif defined(ENABLE_BROWSER_CDMS)
         cdm_manager_,
 #endif
         this);
   }
 
   return cdm_factory_;
 }
 
 }  // namespace content