Make <webview> use out-of-process iframe architecture.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
+#include "content/browser/frame_host/render_frame_proxy_host.h"

[Charlie Reis, 2015/03/10 04:09:44]

Not allowed by DEPS.  web_contents/ can't depend on frame_host/.

[lazyboy, 2015/04/01 21:47:57]

Not required anymore since I moved codes requiring RFPH into RFHM.

 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/process/process.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
@@ skipping 871 matching lines @@
 void WebContentsImpl::CopyMaxPageIDsFrom(WebContents* web_contents) {
   WebContentsImpl* contents = static_cast<WebContentsImpl*>(web_contents);
   max_page_ids_ = contents->max_page_ids_;
 }
 
 SiteInstanceImpl* WebContentsImpl::GetSiteInstance() const {
   return GetRenderManager()->current_host()->GetSiteInstance();
 }
 
 SiteInstanceImpl* WebContentsImpl::GetPendingSiteInstance() const {
+  CHECK(!browser_plugin_guest_);

[Charlie Reis, 2015/03/10 04:09:44]

This doesn't belong in an accessor for the SiteInstance.

[lazyboy, 2015/04/01 21:47:57]

Removed.

   RenderViewHostImpl* dest_rvh =
       GetRenderManager()->pending_render_view_host() ?
           GetRenderManager()->pending_render_view_host() :
           GetRenderManager()->current_host();
   return dest_rvh->GetSiteInstance();
 }
 
 bool WebContentsImpl::IsLoading() const {
   return is_loading_;
 }
@@ skipping 300 matching lines @@
               params.main_frame_routing_id == MSG_ROUTING_NONE) ||
          (params.routing_id != MSG_ROUTING_NONE &&
               params.main_frame_routing_id != MSG_ROUTING_NONE));
   GetRenderManager()->Init(
       params.browser_context, params.site_instance, params.routing_id,
       params.main_frame_routing_id);
 
   WebContentsViewDelegate* delegate =
       GetContentClient()->browser()->GetWebContentsViewDelegate(this);
 
-  if (browser_plugin_guest_) {
-    scoped_ptr<WebContentsView> platform_view(CreateWebContentsView(
-        this, delegate, &render_view_host_delegate_view_));
-
-    WebContentsViewGuest* rv = new WebContentsViewGuest(
-        this, browser_plugin_guest_.get(), platform_view.Pass(),
-        render_view_host_delegate_view_);
-    render_view_host_delegate_view_ = rv;
-    view_.reset(rv);
-  } else {
+//  if (browser_plugin_guest_) {
+//    scoped_ptr<WebContentsView> platform_view(CreateWebContentsView(
+//        this, delegate, &render_view_host_delegate_view_));
+//
+//    WebContentsViewGuest* rv = new WebContentsViewGuest(
+//        this, browser_plugin_guest_.get(), platform_view.Pass(),
+//        render_view_host_delegate_view_);
+//    render_view_host_delegate_view_ = rv;
+//    view_.reset(rv);
+//  } else {
     // Regular WebContentsView.
     view_.reset(CreateWebContentsView(
         this, delegate, &render_view_host_delegate_view_));
-  }
+//  }
   CHECK(render_view_host_delegate_view_);
   CHECK(view_.get());
 
   gfx::Size initial_size = params.initial_size;
   view_->CreateView(initial_size, params.context);
 
   // Listen for whether our opener gets destroyed.
   if (opener_)
     AddDestructionObserver(opener_);
 
@@ skipping 17 matching lines @@
 
   // BrowserPluginGuest::Init needs to be called after this WebContents has
   // a RenderWidgetHostViewGuest. That is, |view_->CreateView| above.
   if (browser_plugin_guest_)
     browser_plugin_guest_->Init();
 
   for (size_t i = 0; i < g_created_callbacks.Get().size(); i++)
     g_created_callbacks.Get().at(i).Run(this);
 }
 
+int WebContentsImpl::AttachLocalFrameToGuest(WebContents* owner_web_contents,

[Charlie Reis, 2015/03/10 04:09:44]

It looks like most of the operations in here probably belong in
RenderFrameHostManager.

[lazyboy, 2015/04/01 21:47:57]

Moved bulk of these to RFHM.

+                                             int embedder_local_render_frame_id,
+                                             int guest_instance_id) {
+  SiteInstance* embedder_si = owner_web_contents->GetSiteInstance();
+  FrameTreeNode* guest_ftn = GetFrameTree()->root();
+
+  RenderFrameHostImpl* embedder_local_frame =
+      RenderFrameHostImpl::FromID(
+          owner_web_contents->GetRenderProcessHost()->GetID(),
+          embedder_local_render_frame_id);

[Charlie Reis, 2015/03/10 04:09:44]

embedder_frame_routing_id?

[lazyboy, 2015/04/01 21:47:58]

Done.

+  DCHECK(embedder_local_frame);
+  FrameTreeNode* embedder_ftn =
+      embedder_local_frame->frame_tree_node();
+
+  FrameTreeNode* embedder_ftn_parent = embedder_ftn->parent();
+  DCHECK(embedder_ftn_parent);
+
+  // TODO: Explain this.
+  guest_ftn->render_manager()->set_pseudo_parent_frame_tree_node_id(
+      embedder_ftn_parent->frame_tree_node_id());
+
+  // Create proxy stuff in Embedder process.
+  int embedder_proxy_flags =
+      CREATE_RF_HIDDEN |
+      CREATE_RF_SWAPPED_OUT |
+      CREATE_RF_FOR_MAIN_FRAME_NAVIGATION;  // ???.
+  int rv_of_embedder_id;

[Charlie Reis, 2015/03/10 04:09:44]

Let's start moving to names that might use in practice, which will make it
easier to follow.

[lazyboy, 2015/04/01 21:47:57]

OK, I've made some changes.

+  scoped_ptr<RenderFrameHostImpl> so_rfh_in_embedder =
+      guest_ftn->render_manager()->CreateRenderFrame(
+          embedder_si,
+          nullptr,
+          MSG_ROUTING_NONE,  // opener_route_id
+          embedder_proxy_flags,
+          &rv_of_embedder_id);
+
+  RenderFrameProxyHost* rfph_in_embedder =
+      guest_ftn->render_manager()->GetRenderFrameProxyHost(
+          embedder_si);
+  DCHECK(rfph_in_embedder);
+  int rfph_in_embedder_routing_id = rfph_in_embedder->GetRoutingID();
+
+  // Send a content message to complete the frame swap.
+  embedder_ftn_parent->current_frame_host()->Send(
+      new FrameMsg_ReplaceLocalFrameWithProxy(
+        embedder_ftn->current_frame_host()->GetRoutingID(),
+        rfph_in_embedder_routing_id));
+
+  // The swapped out render view routing ID will be used to send
+  // postMessage.
+  return rv_of_embedder_id;
+}
+
 void WebContentsImpl::OnWebContentsDestroyed(WebContentsImpl* web_contents) {
   RemoveDestructionObserver(web_contents);
 
   // Clear the opener if it has been closed.
   if (web_contents == opener_) {
     opener_ = NULL;
     return;
   }
   // Clear a pending contents that has been closed before being shown.
   for (PendingContents::iterator iter = pending_contents_.begin();
@@ skipping 221 matching lines @@
   if (delegate_)
     delegate_->LostMouseLock();
 }
 
 void WebContentsImpl::CreateNewWindow(
     int render_process_id,
     int route_id,
     int main_frame_route_id,
     const ViewHostMsg_CreateWindow_Params& params,
     SessionStorageNamespace* session_storage_namespace) {
+  DCHECK(0);
   // We usually create the new window in the same BrowsingInstance (group of
   // script-related windows), by passing in the current SiteInstance.  However,
   // if the opener is being suppressed (in a non-guest), we create a new
   // SiteInstance in its own BrowsingInstance.
   bool is_guest = BrowserPluginGuest::IsGuest(this);
 
   // If the opener is to be suppressed, the new window can be in any process.
   // Since routing ids are process specific, we must not have one passed in
   // as argument here.
   DCHECK(!params.opener_suppressed || route_id == MSG_ROUTING_NONE);
@@ skipping 200 matching lines @@
 
 void WebContentsImpl::ShowCreatedWidget(int route_id,
                                         bool is_fullscreen,
                                         const gfx::Rect& initial_rect) {
   RenderWidgetHostViewBase* widget_host_view =
       static_cast<RenderWidgetHostViewBase*>(GetCreatedWidget(route_id));
   if (!widget_host_view)
     return;
 
   RenderWidgetHostView* view = NULL;
-  BrowserPluginGuest* guest = GetBrowserPluginGuest();
-  if (guest && guest->embedder_web_contents()) {
-    view = guest->embedder_web_contents()->GetRenderWidgetHostView();
-  } else {
+//  BrowserPluginGuest* guest = GetBrowserPluginGuest();
+//  if (guest && guest->embedder_web_contents()) {
+//    view = guest->embedder_web_contents()->GetRenderWidgetHostView();
+//  } else {
     view = GetRenderWidgetHostView();
-  }
+//  }
 
   if (is_fullscreen) {
     DCHECK_EQ(MSG_ROUTING_NONE, fullscreen_widget_routing_id_);
     view_->StoreFocus();
     fullscreen_widget_routing_id_ = route_id;
     if (delegate_ && delegate_->EmbedsFullscreenWidget()) {
       widget_host_view->InitAsChild(GetRenderWidgetHostView()->GetNativeView());
       delegate_->EnterFullscreenModeForTab(this, GURL());
     } else {
       widget_host_view->InitAsFullscreen(view);
@@ skipping 2502 matching lines @@
     int proxy_routing_id,
     bool for_main_frame_navigation) {
   TRACE_EVENT0("browser,navigation",
                "WebContentsImpl::CreateRenderViewForRenderManager");
   // Can be NULL during tests.
   RenderWidgetHostViewBase* rwh_view;
   // TODO(kenrb): RenderWidgetHostViewChildFrame special casing is temporary
   // until RenderWidgetHost is attached to RenderFrameHost. We need to special
   // case this because RWH is still a base class of RenderViewHost, and child
   // frame RWHVs are unique in that they do not have their own WebContents.
-  if (!for_main_frame_navigation) {
+  bool is_guest = GetSiteInstance()->GetSiteURL().SchemeIs("chrome-guest");

[Fady Samuel, 2015/03/04 22:21:06]

Guests are guests if they have a BrowserPluginGuest... Once we call this thing a
GuestProxyHostImpl, then it becomes less scary I think.

[lazyboy, 2015/04/01 21:47:57]

Changed to looking at browser_plugin_guest_ for now.
Done.

+  if (!for_main_frame_navigation || is_guest) {
     RenderWidgetHostViewChildFrame* rwh_view_child =
         new RenderWidgetHostViewChildFrame(render_view_host);
     rwh_view = rwh_view_child;
   } else {
     rwh_view = view_->CreateViewForWidget(render_view_host, false);
   }
 
   // Now that the RenderView has been created, we need to tell it its size.
   if (rwh_view)
     rwh_view->SetSize(GetSizeForNewRenderView());
@@ skipping 135 matching lines @@
 RenderViewHostImpl* WebContentsImpl::GetRenderViewHostImpl() {
   return static_cast<RenderViewHostImpl*>(GetRenderViewHost());
 }
 
 BrowserPluginGuest* WebContentsImpl::GetBrowserPluginGuest() const {
   return browser_plugin_guest_.get();
 }
 
 void WebContentsImpl::SetBrowserPluginGuest(BrowserPluginGuest* guest) {
   CHECK(!browser_plugin_guest_);
+  CHECK(guest);
   browser_plugin_guest_.reset(guest);
 }
 
 BrowserPluginEmbedder* WebContentsImpl::GetBrowserPluginEmbedder() const {
   return browser_plugin_embedder_.get();
 }
 
 void WebContentsImpl::ClearPowerSaveBlockers(
     RenderFrameHost* render_frame_host) {
   RemoveAllMediaPlayerEntries(render_frame_host, &active_audio_players_);
@@ skipping 80 matching lines @@
   node->render_manager()->ResumeResponseDeferredAtStart();
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
 }  // namespace content