content/browser/web_contents/web_contents_node.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/web_contents/web_contents_node.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: some review comments addressed Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/browser/web_contents/web_contents_node.cc » ('j') | content/common/frame_messages.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_NODE_H_

	2 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_NODE_H_

	3

	4 namespace content {

	5

	6 class WebContentsImpl;

	7

	8 class WebContentsNode {
	Charlie Reis 2015/04/08 23:42:11 No one outside WebContentsImpl seems to need this. No one outside WebContentsImpl seems to need this. Can we make it a private struct within WebContentsImpl instead? lazyboy 2015/04/14 01:38:04 Done. Show quoted text On 2015/04/08 23:42:11, Charlie Reis (slow until 4-15) wrote: > No one outside WebContentsImpl seems to need this. Can we make it a private > struct within WebContentsImpl instead? Done.
	9 public:

	10 WebContentsNode();

	11 ~WebContentsNode();

	12

	13 void set_parent_web_contents(WebContentsImpl* parent_web_contents) {

	14 parent_web_contents_ = parent_web_contents;

	15 }

	16 WebContentsImpl* parent_web_contents() {

	17 return parent_web_contents_;

	18 }

	19

	20 private:

	21 WebContentsImpl* parent_web_contents_;

	22 };

	23

	24 } // namespace content

	25

	26 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_NODE_H_

OLD	NEW