Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: some review comments addressed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_proxy_host.h" 5 #include "content/browser/frame_host/render_frame_proxy_host.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "content/browser/frame_host/cross_process_frame_connector.h" 8 #include "content/browser/frame_host/cross_process_frame_connector.h"
9 #include "content/browser/frame_host/frame_tree.h" 9 #include "content/browser/frame_host/frame_tree.h"
10 #include "content/browser/frame_host/frame_tree_node.h" 10 #include "content/browser/frame_host/frame_tree_node.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 site_instance_(site_instance), 46 site_instance_(site_instance),
47 process_(site_instance->GetProcess()), 47 process_(site_instance->GetProcess()),
48 frame_tree_node_(frame_tree_node), 48 frame_tree_node_(frame_tree_node),
49 render_frame_proxy_created_(false) { 49 render_frame_proxy_created_(false) {
50 GetProcess()->AddRoute(routing_id_, this); 50 GetProcess()->AddRoute(routing_id_, this);
51 CHECK(g_routing_id_frame_proxy_map.Get().insert( 51 CHECK(g_routing_id_frame_proxy_map.Get().insert(
52 std::make_pair( 52 std::make_pair(
53 RenderFrameProxyHostID(GetProcess()->GetID(), routing_id_), 53 RenderFrameProxyHostID(GetProcess()->GetID(), routing_id_),
54 this)).second); 54 this)).second);
55 55
56 if (!frame_tree_node_->IsMainFrame() && 56 // If this is a proxy to embedder created in the guest's FTN, then we
57 // need a CrossProcessFrameConnector.
58 bool is_proxy_to_embedder_for_guest =
59 frame_tree_node_->IsMainFrame() &&
60 frame_tree_node_->render_manager()->current_frame_host()
61 ->GetSiteInstance()->GetSiteURL().SchemeIs("chrome-guest");
62 if ((!frame_tree_node_->IsMainFrame() &&
57 frame_tree_node_->parent() 63 frame_tree_node_->parent()
58 ->render_manager() 64 ->render_manager()
59 ->current_frame_host() 65 ->current_frame_host()
60 ->GetSiteInstance() == site_instance) { 66 ->GetSiteInstance() == site_instance) ||
67 is_proxy_to_embedder_for_guest) {
61 // The RenderFrameHost navigating cross-process is destroyed and a proxy for 68 // The RenderFrameHost navigating cross-process is destroyed and a proxy for
62 // it is created in the parent's process. CrossProcessFrameConnector 69 // it is created in the parent's process. CrossProcessFrameConnector
63 // initialization only needs to happen on an initial cross-process 70 // initialization only needs to happen on an initial cross-process
64 // navigation, when the RenderFrameHost leaves the same process as its 71 // navigation, when the RenderFrameHost leaves the same process as its
65 // parent. The same CrossProcessFrameConnector is used for subsequent cross- 72 // parent. The same CrossProcessFrameConnector is used for subsequent cross-
66 // process navigations, but it will be destroyed if the frame is 73 // process navigations, but it will be destroyed if the frame is
67 // navigated back to the same SiteInstance as its parent. 74 // navigated back to the same SiteInstance as its parent.
68 cross_process_frame_connector_.reset(new CrossProcessFrameConnector(this)); 75 cross_process_frame_connector_.reset(new CrossProcessFrameConnector(this));
69 } 76 }
70 } 77 }
(...skipping 11 matching lines...) Expand all
82 GetProcess()->RemoveRoute(routing_id_); 89 GetProcess()->RemoveRoute(routing_id_);
83 g_routing_id_frame_proxy_map.Get().erase( 90 g_routing_id_frame_proxy_map.Get().erase(
84 RenderFrameProxyHostID(GetProcess()->GetID(), routing_id_)); 91 RenderFrameProxyHostID(GetProcess()->GetID(), routing_id_));
85 } 92 }
86 93
87 void RenderFrameProxyHost::SetChildRWHView(RenderWidgetHostView* view) { 94 void RenderFrameProxyHost::SetChildRWHView(RenderWidgetHostView* view) {
88 cross_process_frame_connector_->set_view( 95 cross_process_frame_connector_->set_view(
89 static_cast<RenderWidgetHostViewChildFrame*>(view)); 96 static_cast<RenderWidgetHostViewChildFrame*>(view));
90 } 97 }
91 98
99 // TODO(lazyboy): We can probably cache a pointer to RVH in this class
100 // as we do in RenderFrameHostImpl.
92 RenderViewHostImpl* RenderFrameProxyHost::GetRenderViewHost() { 101 RenderViewHostImpl* RenderFrameProxyHost::GetRenderViewHost() {
93 return frame_tree_node_->frame_tree()->GetRenderViewHost( 102 // RVH of embedder site instance does not live in the guest RFHM, we need
94 site_instance_.get()); 103 // to look it up in the embedder's FrameTree.
104 RenderFrameProxyHost* proxy_to_embedder =
105 frame_tree_node_->render_manager()->GetProxyToEmbedder();
106 FrameTree* frame_tree = proxy_to_embedder ?
107 proxy_to_embedder->frame_tree_node_->frame_tree() :
108 frame_tree_node_->frame_tree();
109 return frame_tree->GetRenderViewHost(site_instance_.get());
95 } 110 }
96 111
97 void RenderFrameProxyHost::TakeFrameHostOwnership( 112 void RenderFrameProxyHost::TakeFrameHostOwnership(
98 scoped_ptr<RenderFrameHostImpl> render_frame_host) { 113 scoped_ptr<RenderFrameHostImpl> render_frame_host) {
99 render_frame_host_ = render_frame_host.Pass(); 114 render_frame_host_ = render_frame_host.Pass();
100 render_frame_host_->set_render_frame_proxy_host(this); 115 render_frame_host_->set_render_frame_proxy_host(this);
101 } 116 }
102 117
103 scoped_ptr<RenderFrameHostImpl> RenderFrameProxyHost::PassFrameHostOwnership() { 118 scoped_ptr<RenderFrameHostImpl> RenderFrameProxyHost::PassFrameHostOwnership() {
104 render_frame_host_->set_render_frame_proxy_host(NULL); 119 render_frame_host_->set_render_frame_proxy_host(NULL);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 void RenderFrameProxyHost::DisownOpener() { 171 void RenderFrameProxyHost::DisownOpener() {
157 Send(new FrameMsg_DisownOpener(GetRoutingID())); 172 Send(new FrameMsg_DisownOpener(GetRoutingID()));
158 } 173 }
159 174
160 void RenderFrameProxyHost::OnOpenURL( 175 void RenderFrameProxyHost::OnOpenURL(
161 const FrameHostMsg_OpenURL_Params& params) { 176 const FrameHostMsg_OpenURL_Params& params) {
162 frame_tree_node_->current_frame_host()->OpenURL(params, site_instance_.get()); 177 frame_tree_node_->current_frame_host()->OpenURL(params, site_instance_.get());
163 } 178 }
164 179
165 } // namespace content 180 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698