chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java - Issue 972303002: Fix RoundedIconGenerator font scaling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java

Issue 972303002: Fix RoundedIconGenerator font scaling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java

index 17dab5a6af322d1b661145c2044708d5bc82d8cb..d4d00168ed6524860fff58d6e757ea3567823c72 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java

@@ -46,7 +46,7 @@ class WebsitePreference extends Preference implements FaviconImageCallback {

private static final int FAVICON_CORNER_RADIUS_DP = 2;

private static final int FAVICON_SIZE_DP = 16;

private static final int FAVICON_PADDING_DP = 4;

- private static final int FAVICON_TEXT_SIZE_SP = 10;

+ private static final int FAVICON_TEXT_SIZE_DP = 10;

private static final int FAVICON_BACKGROUND_COLOR = 0xff969696;

WebsitePreference(Context context, Website site, String categoryFilter) {

@@ -86,7 +86,7 @@ class WebsitePreference extends Preference implements FaviconImageCallback {

RoundedIconGenerator faviconGenerator = new RoundedIconGenerator(

getContext(), FAVICON_SIZE_DP, FAVICON_SIZE_DP,

FAVICON_CORNER_RADIUS_DP, FAVICON_BACKGROUND_COLOR,

- FAVICON_TEXT_SIZE_SP);

+ FAVICON_TEXT_SIZE_DP);

image = faviconGenerator.generateIconForUrl(faviconUrl());

}