Source/platform/SharedBuffer.cpp - Issue 972283002: Remove reserveCapacity call from SharedBuffer::mergeSegmentsIntoBuffer().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/SharedBuffer.cpp

Issue 972283002: Remove reserveCapacity call from SharedBuffer::mergeSegmentsIntoBuffer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/SharedBuffer.cpp

diff --git a/Source/platform/SharedBuffer.cpp b/Source/platform/SharedBuffer.cpp

index 2f0e9cb54e291cd101b6c706b12aba8e9b4a0f73..1b1483773368bdf78a7582a5efe3c35470073d09 100644

--- a/Source/platform/SharedBuffer.cpp

+++ b/Source/platform/SharedBuffer.cpp

@@ -312,7 +312,6 @@ void SharedBuffer::mergeSegmentsIntoBuffer() const

{

unsigned bufferSize = m_buffer.size();

if (m_size > bufferSize) {

- m_buffer.reserveCapacity(m_size);

unsigned bytesLeft = m_size - bufferSize;

for (unsigned i = 0; i < m_segments.size(); ++i) {

unsigned bytesToCopy = std::min(bytesLeft, segmentSize);

« no previous file with comments | « no previous file | no next file » | no next file with comments »