[Cronet] Implement batch read in CronetInputStream

components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.urlconnection;
 
 import android.os.Build;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.test.util.Feature;
 import org.chromium.net.CronetTestActivity;
 import org.chromium.net.CronetTestBase;
+import org.chromium.net.MockUrlRequestJobFactory;
 import org.chromium.net.NativeTestServer;
 import org.chromium.net.UrlRequestContextConfig;
 import org.chromium.net.UrlRequestException;
 
 import java.io.ByteArrayOutputStream;
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
@@ skipping 448 matching lines @@
         byte[] readSomeMore = new byte[10];
         int bytesReadBeyondAvailable  = in.read(readSomeMore, 0, 10);
         urlConnection.disconnect();
         assertEquals(testInputBytes.length, bytesRead);
         assertEquals(-1, bytesReadBeyondAvailable);
         for (int i = 0; i < bytesRead; i++) {
             assertEquals(testInputBytes[i], actualOutput[i]);
         }
     }
 
+    /**
+     * Tests batch reading on CronetInputStream when
+     * {@link CronetHttpURLConnection#getMoreData} is called multiple times.
+     */
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunCronetHttpURLConnection
+    public void testBigDataRead() throws Exception {
+        String data = "MyBigFunkyData";
+        int dataLength = data.length();
+        int repeatCount = 100000;
+        MockUrlRequestJobFactory mMockUrlRequestJobFactory = new MockUrlRequestJobFactory(
+                getInstrumentation().getTargetContext());
+        URL url = new URL(mMockUrlRequestJobFactory.getMockUrlForData(data,
+                repeatCount));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        InputStream in = connection.getInputStream();
+        byte[] actualOutput = new byte[dataLength * repeatCount];

[mmenke, 2015/03/05 21:42:21]

Suggest another test where we only have X body bytes, and try to use reads of Y
> X (to a Y + X size buffer).  The guarantees that we handle the case we try to
read beyond the end of a buffer, while this tests the case we read exactly to
the end of the buffer.

[xunjieli, 2015/03/06 15:21:23]

Is this the same as testInputStreamReadMoreBytesThanAvailable (the test above
this one), where we try to read more than what's in the buffer?

[mmenke, 2015/03/06 16:42:16]

Oops.  Yea, it is.

+        int totalBytesRead = 0;
+        // Number of bytes to read each time. It is incremented by one from 0.
+        int numBytesToRead = 0;
+        while (totalBytesRead < actualOutput.length) {
+            if (actualOutput.length - totalBytesRead < numBytesToRead) {
+                // Do not read out of bound.
+                numBytesToRead = actualOutput.length - totalBytesRead;
+            }
+            int bytesRead = in.read(actualOutput, totalBytesRead, numBytesToRead);
+            assertTrue(bytesRead <= numBytesToRead);
+            totalBytesRead += bytesRead;
+            numBytesToRead++;
+        }
+
+        // All data has been read. Try reading beyond what is available should give -1.
+        assertEquals(0, in.read(actualOutput, 0, 0));
+        assertEquals(-1, in.read(actualOutput, 0, 1));
+
+        String responseData = new String(actualOutput);
+        for (int i = 0; i < repeatCount; ++i) {
+            assertEquals(data, responseData.substring(dataLength * i,
+                    dataLength * (i + 1)));
+        }
+        // TODO(xunjieli): Enable after crbug.com/463720 is fixed.
+        // assertEquals(200, connection.getResponseCode());
+        // assertEquals("OK", connection.getResponseMessage());
+    }
+
     @SmallTest
     @Feature({"Cronet"})
     @CompareDefaultWithCronet
     public void testInputStreamReadExactBytesAvailable() throws Exception {
         String testInputString = "this is a really long header";
         byte[] testInputBytes = testInputString.getBytes();
         URL url = new URL(NativeTestServer.getEchoHeaderURL("foo"));
         HttpURLConnection urlConnection =
                 (HttpURLConnection) url.openConnection();
         urlConnection.addRequestProperty("foo", testInputString);
@@ skipping 360 matching lines @@
             String headerName) {
         Pattern pattern = Pattern.compile(headerName + ":\\s(.*)\\r\\n");
         Matcher matcher = pattern.matcher(allHeaders);
         List<String> headerValues = new ArrayList<String>();
         while (matcher.find()) {
             headerValues.add(matcher.group(1));
         }
         return headerValues;
     }
 }