include library prefix suggestions when suggesting constructors

pkg/analysis_server/test/completion_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.completion.support;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:unittest/unittest.dart';
@@ skipping 221 matching lines @@
 class L{var k;void.!1}''', <String>["1-k"]);
 
     buildTests('testCommentSnippets044', '''
 class List{}class XXX {XXX.fisk();}main() {main(); new !1}}''',
         <String>["1+List", "1+XXX.fisk"], failingTests: '1');
 
     buildTests('testCommentSnippets047', '''
 f(){int x;int y=!1;}''', <String>["1+x"]);
 
     buildTests('testCommentSnippets048', '''
-import 'dart:convert' as json;f() {var x=new js!1}''', <String>["1+json"], failingTests: '1');
+import 'dart:convert' as json;f() {var x=new js!1}''', <String>["1+json"]);
 
     buildTests('testCommentSnippets049', '''
 import 'dart:convert' as json;
 import 'dart:convert' as jxx;
 class JsonDecoderX{}
 f1() {var x=new !2j!1s!3}''', <String>[
       "1+json",
       "1+jxx",
       "2+json",
       "2+jxx",
       "2-JsonDecoder",
       "3+json",
       "3-jxx"
-    ], failingTests: '123');
+    ]);
 
     buildTests('testCommentSnippets050', '''
 class xdr {
   xdr();
   const xdr.a(a,b,c);
   xdr.b();
   f() => 3;
 }
 class xa{}
 k() {
   new x!1dr().f();
   const x!2dr.!3a(1, 2, 3);
 }''', <String>[
       "1+xdr",
       "1+xa",
       "1+xdr.a",
       "1+xdr.b",
-      "2-xa",
-      "2-xdr",
+      "2+xa", // suggest default constructor
+      "2+xdr", // suggest normal constructor
       "2+xdr.a",
-      "2-xdr.b",
-      "3-b",
+      "2+xdr.b", // suggest named constructor
+      "3+b", // suggest named constructor
       "3+a"
-    ], failingTests: '23');
+    ]);
 
     // Type propagation.
     buildTests('testCommentSnippets051', '''
 class String{int length(){} String toUpperCase(){} bool isEmpty(){}}class Map{getKeys(){}}
 void r() {
   var v;
   if (v is String) {
     v.!1length;
     v.!2getKeys;
   }
@@ skipping 983 matching lines @@
 class A {A({foo, bar}) {}} main() { new A(fo!1); }''',
         <String>["1+foo", "1-bar"], failingTests: '1');
 
     buildTests('testCompletion_namedArgument_empty', '''
 func({foo, bar}) {} main() { func(!1); }''', <String>[
       "1+foo" /*":" + ProposalKind.NAMED_ARGUMENT*/,
       "1-foo" /*":" + ProposalKind.OPTIONAL_ARGUMENT*/
     ], failingTests: '1');
 
     buildTests('testCompletion_namedArgument_function', '''
-func({foo, bar}) {} main() { func(fo!1); }''', <String>["1+foo", "1-bar"],
-        failingTests: '1');
+func({foo, bar}) {} main() { func(fo!1); }''',
+        <String>["1+foo", "1-bar"], failingTests: '1');
 
     buildTests('testCompletion_namedArgument_notNamed', '''
 func([foo]) {} main() { func(fo!1); }''', <String>["1-foo"]);
 
     buildTests('testCompletion_namedArgument_unresolvedFunction', '''
 main() { func(fo!1); }''', <String>["1-foo"]);
 
     buildTests('testCompletion_newMemberType1', '''
 class Collection{}class List extends Collection{}class Foo { !1 }''',
         <String>["1+Collection", "1+List"], failingTests: '1');
@@ skipping 1001 matching lines @@
       } else {
         ++expectedPassCount;
         tester(testName, () {
           CompletionTestCase test = new CompletionTestCase();
           return test.runTest(spec, extraFiles);
         });
       }
     }
   }
 }