Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

Issue 972153002: [bindings] Remove custom binding usage in SQLResultSetRowList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@test
Patch Set: Patch for landing Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/modules/v8/ToV8ForModules.h ('k') | Source/bindings/modules/v8/custom/custom.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp
diff --git a/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp b/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp
deleted file mode 100644
index 1179ae6690138463c252d14d7cff9db30460af9a..0000000000000000000000000000000000000000
--- a/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp
+++ /dev/null
@@ -1,93 +0,0 @@
-/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "bindings/modules/v8/V8SQLResultSetRowList.h"
-
-#include "bindings/core/v8/ExceptionMessages.h"
-#include "bindings/core/v8/ExceptionState.h"
-#include "bindings/core/v8/V8Binding.h"
-#include "core/dom/ExceptionCode.h"
-#include "modules/webdatabase/SQLResultSetRowList.h"
-
-namespace blink {
-
-void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- ExceptionState exceptionState(ExceptionState::ExecutionContext, "item", "SQLResultSetRowList", info.Holder(), info.GetIsolate());
- if (!info.Length()) {
- exceptionState.throwDOMException(SyntaxError, ExceptionMessages::notEnoughArguments(1, 0));
- exceptionState.throwIfNeeded();
- return;
- }
-
- if (!info[0]->IsNumber()) {
- exceptionState.throwTypeError("The index provided is not a number.");
- exceptionState.throwIfNeeded();
- return;
- }
-
- SQLResultSetRowList* rowList = V8SQLResultSetRowList::toImpl(info.Holder());
-
- unsigned long index = info[0]->IntegerValue();
- if (index >= rowList->length()) {
- exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::indexExceedsMaximumBound<unsigned>("index", index, rowList->length()));
- exceptionState.throwIfNeeded();
- return;
- }
-
- v8::Local<v8::Object> item = v8::Object::New(info.GetIsolate());
- unsigned numColumns = rowList->columnNames().size();
- unsigned valuesIndex = index * numColumns;
-
- for (unsigned i = 0; i < numColumns; ++i) {
- const SQLValue& sqlValue = rowList->values()[valuesIndex + i];
- v8::Local<v8::Value> value;
- switch (sqlValue.type()) {
- case SQLValue::StringValue:
- value = v8String(info.GetIsolate(), sqlValue.string());
- break;
- case SQLValue::NullValue:
- value = v8::Null(info.GetIsolate());
- break;
- case SQLValue::NumberValue:
- value = v8::Number::New(info.GetIsolate(), sqlValue.number());
- break;
- default:
- ASSERT_NOT_REACHED();
- }
-
- item->ForceSet(v8String(info.GetIsolate(), rowList->columnNames()[i]), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));
- }
-
- v8SetReturnValue(info, item);
-}
-
-} // namespace blink
« no previous file with comments | « Source/bindings/modules/v8/ToV8ForModules.h ('k') | Source/bindings/modules/v8/custom/custom.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698