[bindings] Remove custom binding usage in SQLResultSetRowList.

Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

-/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- *     * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- *     * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "bindings/modules/v8/V8SQLResultSetRowList.h"
-
-#include "bindings/core/v8/ExceptionMessages.h"
-#include "bindings/core/v8/ExceptionState.h"
-#include "bindings/core/v8/V8Binding.h"
-#include "core/dom/ExceptionCode.h"
-#include "modules/webdatabase/SQLResultSetRowList.h"
-
-namespace blink {
-
-void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
-    ExceptionState exceptionState(ExceptionState::ExecutionContext, "item", "SQLResultSetRowList", info.Holder(), info.GetIsolate());
-    if (!info.Length()) {
-        exceptionState.throwDOMException(SyntaxError, ExceptionMessages::notEnoughArguments(1, 0));
-        exceptionState.throwIfNeeded();
-        return;
-    }
-
-    if (!info[0]->IsNumber()) {
-        exceptionState.throwTypeError("The index provided is not a number.");
-        exceptionState.throwIfNeeded();
-        return;
-    }
-
-    SQLResultSetRowList* rowList = V8SQLResultSetRowList::toImpl(info.Holder());
-
-    unsigned long index = info[0]->IntegerValue();
-    if (index >= rowList->length()) {

[haraken, 2015/03/05 09:03:13]

Just to confirm: Is this condition covered in the auto-generated code?

[vivekg, 2015/03/05 09:13:53]

This is not covered by the generated code. There must be an explicit check as
done in SQLResultSetRowList::item() in SQLResultSetRowList.cpp

-        exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::indexExceedsMaximumBound<unsigned>("index", index, rowList->length()));
-        exceptionState.throwIfNeeded();
-        return;
-    }
-
-    v8::Local<v8::Object> item = v8::Object::New(info.GetIsolate());
-    unsigned numColumns = rowList->columnNames().size();
-    unsigned valuesIndex = index * numColumns;
-
-    for (unsigned i = 0; i < numColumns; ++i) {
-        const SQLValue& sqlValue = rowList->values()[valuesIndex + i];
-        v8::Local<v8::Value> value;
-        switch (sqlValue.type()) {
-        case SQLValue::StringValue:
-            value = v8String(info.GetIsolate(), sqlValue.string());
-            break;
-        case SQLValue::NullValue:
-            value = v8::Null(info.GetIsolate());
-            break;
-        case SQLValue::NumberValue:
-            value = v8::Number::New(info.GetIsolate(), sqlValue.number());
-            break;
-        default:
-            ASSERT_NOT_REACHED();
-        }
-
-        item->ForceSet(v8String(info.GetIsolate(), rowList->columnNames()[i]), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));

[haraken, 2015/03/05 09:03:13]

This CL is changing behavior since you're changing ForceSet to Set, but I
believe it doesn't matter (ForceSet is discouraged).

[vivekg, 2015/03/05 09:13:53]

Yeah, you are right. Its doesn't matter here.

-    }
-
-    v8SetReturnValue(info, item);
-}
-
-} // namespace blink