Source/bindings/modules/v8/ScriptValueUtilities.h - Issue 972153002: [bindings] Remove custom binding usage in SQLResultSetRowList.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/modules/v8/ScriptValueUtilities.h

Issue 972153002: [bindings] Remove custom binding usage in SQLResultSetRowList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@test

Patch Set: Review comments addressed! Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/bindings/core/v8/ToV8Test.cpp ('K') | « Source/bindings/core/v8/ToV8Test.cpp ('k') | Source/bindings/modules/v8/ToV8Utilities.h » ('j') | Source/modules/webdatabase/SQLResultSetRowList.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ScriptValueUtilities_h

	6 #define ScriptValueUtilities_h

	7

	8 #include "bindings/core/v8/ScriptValue.h"

	9 #include "bindings/core/v8/ToV8.h"

	10 #include "bindings/modules/v8/ToV8Utilities.h"

	11 #include "modules/webdatabase/sqlite/SQLValue.h"

	12

	13 namespace blink {

	14

	15 ScriptValue toScriptValue(const Vector<std::pair<String, SQLValue>>& value)

	16 {

	17 v8::Isolate* isolate = v8::Isolate::GetCurrent();

	18 ScriptState* scriptState = ScriptState::current(isolate);
	Jens Widell 2015/03/04 15:53:27 It would be better if this function just took a Sc It would be better if this function just took a ScriptState* argument. If you add [CallWith=ScriptState] in the IDL, SQLResultSetRowList::item() will be called with a ScriptState* as the first argument.
	19 RELEASE_ASSERT(scriptState);

	20 return ScriptValue(scriptState, toV8(value, scriptState->context()->Global() , isolate));

	21 }

	22

	23 } // namespace blink

	24

	25 #endif // ScriptValueUtilities_h

OLD	NEW