[bindings] Remove custom binding usage in SQLResultSetRowList.

Source/bindings/core/v8/ToV8.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ToV8_h
 #define ToV8_h
 
 #include "bindings/core/v8/DOMDataStore.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/ScriptWrappable.h"
@@ skipping 192 matching lines @@
         array->Set(v8::Integer::New(isolate, index++), toV8(*iter, creationContext, isolate));
     return array;
 }
 
 template<typename T, size_t inlineCapacity>
 inline v8::Handle<v8::Value> toV8(const Vector<T, inlineCapacity>& value, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return toV8SequenceInternal(value, creationContext, isolate);
 }
 
+template<typename T>
+inline v8::Handle<v8::Value> toV8(const Vector<std::pair<String, T>>& value, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

[Yuki, 2015/03/04 14:11:04]

Since both of toV8(Vector<T>) and toV8(HeapVector<T>) returns v8::Array, and
both of them use toV8SequenceInternal, I think these two are closer to each
other than your new toV8(Vector<pair>).  So I'd prefer put this new function at
the end of the file (after HeapVector version).

+{
+    v8::Local<v8::Object> object = v8::Object::New(isolate);
+    for (unsigned i = 0; i < value.size(); ++i)
+        object->Set(v8String(isolate, value[i].first), value[i].second);

[Jens Widell, 2015/03/04 13:53:52]

By passing value[i].second directly to v8::Object::Set(), you are in fact
depending on T=v8::Handle<v8::Value>.

It would make more sense if the second argument to object->Set() was

  toV8(value[i].second, creationContext, isolate)

You could then call this with a Vector<std::pair<String, SQLValue>> argument
instead.

[vivekg, 2015/03/04 13:57:19]

Thanks Jens, I did the same thing initially. 
Though that would create a dependency on modules/v8/ToV8.h which needs to be
included in the core which I thought would be a layering violation. No? 

[Jens Widell, 2015/03/04 14:03:54]

It would certainly be wrong to include modules/v8/ToV8.h from core/v8/ToV8.h,
but luckily there would be no need for that. You would only need to have
included modules/v8/ToV8.h at the point where you call this toV8() function with
such an argument. (Which you already do.)

[Yuki, 2015/03/04 14:11:04]

Please use
  toV8(value[i].second, creationContext, isolate)
for the value so we can pass any v8-convertible types.
(Otherwise template<typename T> is meaningless.)

See toV8SequenceInternal() in this file for reference.

+    return object;
+}
+
 template<typename T, size_t inlineCapacity>
 inline v8::Handle<v8::Value> toV8(const HeapVector<T, inlineCapacity>& value, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return toV8SequenceInternal(value, creationContext, isolate);
 }
 
 } // namespace blink
 
 #endif // ToV8_h