[bindings] Remove custom binding usage in SQLResultSetRowList.

Source/modules/webdatabase/SQLResultSetRowList.cpp

 /*
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 11 matching lines @@
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/webdatabase/SQLResultSetRowList.h"
 
+#include "bindings/core/v8/V8Binding.h"
+
 namespace blink {
 
 unsigned SQLResultSetRowList::length() const
 {
     if (m_result.size() == 0)
         return 0;
 
     ASSERT(m_result.size() % m_columns.size() == 0);
 
     return m_result.size() / m_columns.size();
 }
 
+ScriptValue SQLResultSetRowList::item(unsigned index, ExceptionState&)

[haraken, 2015/03/03 15:02:00]

This function contains a bunch of V8 APIs. In terms of DEPS, it is OK to use V8
APIs in core/ and modules/, but in terms of code health, we want to limit usages
of V8 APIs into bindings/ because it's hard for ordinary developers to use V8
APIs correctly.

+{
+    v8::Isolate* isolate = v8::Isolate::GetCurrent();
+    v8::Local<v8::Object> item = v8::Object::New(isolate);
+    unsigned numColumns = m_columns.size();
+    unsigned valuesIndex = index * numColumns;
+
+    for (unsigned i = 0; i < numColumns; ++i) {
+        const SQLValue& sqlValue = m_result[valuesIndex + i];
+        v8::Local<v8::Value> value;
+        switch (sqlValue.type()) {
+        case SQLValue::StringValue:
+            value = v8String(isolate, sqlValue.string());
+            break;
+        case SQLValue::NullValue:
+            value = v8::Null(isolate);
+            break;
+        case SQLValue::NumberValue:
+            value = v8::Number::New(isolate, sqlValue.number());
+            break;
+        default:
+            ASSERT_NOT_REACHED();
+        }
+        item->ForceSet(v8String(isolate, m_columns[i]), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));

[haraken, 2015/03/04 04:06:35]

I'm wondering why this is using ForceSet. I think this can be a normal Set.

+    }
+    return ScriptValue(ScriptState::current(isolate), item);
 }
+
+}