Issue 972133002: Revert of Handle unpatched VS xtree header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 972133002: Revert of Handle unpatched VS xtree header (Closed)

Created:
5 years, 9 months ago by ulan

Modified:
5 years, 9 months ago

Reviewers:
brettw, Tomasz Moniuszko

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Handle unpatched VS xtree header (patchset #3 id:40001 of https://codereview.chromium.org/965713002/) Reason for revert: This broke Win 8 GN builders: ERROR at //build/config/compiler/BUILD.gn:804:30: Assignment had no effect. msvs_xtree_patched = true Original issue's description: > Handle unpatched VS xtree header > > BUG= > > Committed: https://crrev.com/b5020725ac56d11c064086295af7db628b4fe64b > Cr-Commit-Position: refs/heads/master@{#318859} TBR=brettw@chromium.org,tmoniuszko@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/420ba82a866f64e26bad84fe3a384f74413f8ef2 Cr-Commit-Position: refs/heads/master@{#318861}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	build/config/compiler/BUILD.gn	View		2 chunks	+0 lines, -18 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972133002/1

5 years, 9 months ago (2015-03-03 10:57:36 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-03 10:59:05 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/420ba82a866f64e26bad84fe3a384f74413f8ef2
Cr-Commit-Position: refs/heads/master@{#318861}