Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: chrome/browser/devtools/devtools_window_testing.cc

Issue 972123003: Fixed behavior in case of disabled devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed conflict Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_window_testing.h" 5 #include "chrome/browser/devtools/devtools_window_testing.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "chrome/browser/devtools/devtools_window.h" 8 #include "chrome/browser/devtools/devtools_window.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_window.h" 10 #include "chrome/browser/ui/browser_window.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 runner->Run(); 99 runner->Run();
100 } 100 }
101 101
102 // static 102 // static
103 DevToolsWindow* DevToolsWindowTesting::OpenDevToolsWindowSync( 103 DevToolsWindow* DevToolsWindowTesting::OpenDevToolsWindowSync(
104 content::WebContents* inspected_web_contents, 104 content::WebContents* inspected_web_contents,
105 bool is_docked) { 105 bool is_docked) {
106 std::string settings = is_docked ? 106 std::string settings = is_docked ?
107 "{\"currentDockState\":\"\\\"bottom\\\"\"}" : 107 "{\"currentDockState\":\"\\\"bottom\\\"\"}" :
108 "{\"currentDockState\":\"\\\"undocked\\\"\"}"; 108 "{\"currentDockState\":\"\\\"undocked\\\"\"}";
109 DevToolsWindow* window = DevToolsWindow::ToggleDevToolsWindow( 109 scoped_refptr<content::DevToolsAgentHost> agent(
110 inspected_web_contents, true, DevToolsToggleAction::Show(), settings); 110 content::DevToolsAgentHost::GetOrCreateFor(inspected_web_contents));
111 DevToolsWindow::ToggleDevToolsWindow(
112 inspected_web_contents, true, DevToolsToggleAction::Show(), settings);
113 DevToolsWindow* window = DevToolsWindow::FindDevToolsWindow(agent.get());
111 WaitForDevToolsWindowLoad(window); 114 WaitForDevToolsWindowLoad(window);
112 return window; 115 return window;
113 } 116 }
114 117
115 // static 118 // static
116 DevToolsWindow* DevToolsWindowTesting::OpenDevToolsWindowSync( 119 DevToolsWindow* DevToolsWindowTesting::OpenDevToolsWindowSync(
117 Browser* browser, 120 Browser* browser,
118 bool is_docked) { 121 bool is_docked) {
119 return OpenDevToolsWindowSync( 122 return OpenDevToolsWindowSync(
120 browser->tab_strip_model()->GetActiveWebContents(), is_docked); 123 browser->tab_strip_model()->GetActiveWebContents(), is_docked);
(...skipping 20 matching lines...) Expand all
141 144
142 // static 145 // static
143 void DevToolsWindowTesting::CloseDevToolsWindowSync( 146 void DevToolsWindowTesting::CloseDevToolsWindowSync(
144 DevToolsWindow* window) { 147 DevToolsWindow* window) {
145 scoped_refptr<content::MessageLoopRunner> runner = 148 scoped_refptr<content::MessageLoopRunner> runner =
146 new content::MessageLoopRunner; 149 new content::MessageLoopRunner;
147 DevToolsWindowTesting::Get(window)->SetCloseCallback(runner->QuitClosure()); 150 DevToolsWindowTesting::Get(window)->SetCloseCallback(runner->QuitClosure());
148 CloseDevToolsWindow(window); 151 CloseDevToolsWindow(window);
149 runner->Run(); 152 runner->Run();
150 } 153 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698