Fixed behavior in case of disabled devtools

chrome/browser/devtools/devtools_sanity_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/cancelable_callback.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_timeouts.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/browser_list_tabcontents_provider.h"
 #include "chrome/browser/devtools/devtools_window_testing.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/test_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/app_modal/javascript_app_modal_dialog.h"
 #include "components/app_modal/native_app_modal_dialog.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/devtools_http_handler.h"
@@ skipping 107 matching lines @@
     return DevToolsWindowTesting::Get(window_)->main_web_contents();
   }
 
   WebContents* toolbox_web_contents() {
     return DevToolsWindowTesting::Get(window_)->toolbox_web_contents();
   }
 
   DevToolsWindow* window_;
 };
 
+
+class DevToolsPolicyTest : public InProcessBrowserTest {
+ public:
+  DevToolsPolicyTest() : window_(NULL) {}
+
+ protected:
+  void OpenDevToolsWindowAndAgentHost(const std::string& test_page) {

[dgozman, 2015/03/10 19:36:34]

|test_page| not used.

+    ASSERT_TRUE(test_server()->Start());

[dgozman, 2015/03/10 19:36:34]

Don't start test server.

+    GURL url("about:blank");

[dgozman, 2015/03/10 19:36:34]

inline

+    ui_test_utils::NavigateToURL(browser(), url);
+    content::WebContents* web_contents =
+        browser()->tab_strip_model()->GetWebContentsAt(0);
+    scoped_refptr<content::DevToolsAgentHost> agent(
+        content::DevToolsAgentHost::GetOrCreateFor(web_contents));
+    DevToolsWindow::OpenDevToolsWindow(web_contents);
+    window_ = DevToolsWindow::FindDevToolsWindow(agent.get());
+  }
+
+  void SetPolicyDevToolsDisabled(bool value) {
+    browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsDisabled,
+                                                 value);
+  }
+
+  bool WindowExists() { return window_; }
+
+  DevToolsWindow* window_;
+};
+
+
 // Used to block until a dev tools window gets beforeunload event.
 class DevToolsWindowBeforeUnloadObserver
     : public content::WebContentsObserver {
  public:
   explicit DevToolsWindowBeforeUnloadObserver(DevToolsWindow*);
   void Wait();
  private:
   // Invoked when the beforeunload handler fires.
   void BeforeUnloadFired(const base::TimeTicks& proceed_time) override;
 
@@ skipping 699 matching lines @@
   ASSERT_TRUE(
       content::ExecuteScriptAndExtractString(
           main_web_contents()->GetRenderViewHost(),
           "window.domAutomationController.send("
           "    '' + (window.uiTests && (typeof uiTests.runTest)));",
           &result));
   ASSERT_EQ("function", result) << "DevTools front-end is broken.";
   CloseDevToolsWindow();
 }
 
+IN_PROC_BROWSER_TEST_F(DevToolsPolicyTest, PolicyTrue) {
+  SetPolicyDevToolsDisabled(true);
+  OpenDevToolsWindowAndAgentHost(kDebuggerTestPage);
+  ASSERT_FALSE(WindowExists());
+}
+
+IN_PROC_BROWSER_TEST_F(DevToolsPolicyTest, PolicyFalse) {

[dgozman, 2015/03/10 19:36:34]

I don't think this tests anything. I'd rather remove it and inline all the
methods into previous test, removing the class.

+  SetPolicyDevToolsDisabled(false);
+  OpenDevToolsWindowAndAgentHost(kDebuggerTestPage);
+  ASSERT_TRUE(WindowExists());
+}
+
 IN_PROC_BROWSER_TEST_F(WorkerDevToolsSanityTest, InspectSharedWorker) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kAshBrowserTests))
     return;
 #endif
 
   RunTest("testSharedWorker", kSharedWorkerTestPage, kSharedWorkerTestWorker);
 }
@@ skipping 60 matching lines @@
 IN_PROC_BROWSER_TEST_F(RemoteDebuggingTest, MAYBE_RemoteDebugger) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kAshBrowserTests))
     return;
 #endif
 
   ASSERT_TRUE(RunExtensionTest("target_list")) << message_;
 }