Issue 972123002: [iOS] Fix DCHECK in ShouldShowAlwaysTranslateShortcut()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 972123002: [iOS] Fix DCHECK in ShouldShowAlwaysTranslateShortcut() (Closed)

Created:
5 years, 9 months ago by droger

Modified:
5 years, 9 months ago

Reviewers:
sdefresne

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[iOS] Fix DCHECK in ShouldShowAlwaysTranslateShortcut() This CL upstreams a small fork in ShouldShowAlwaysTranslateShortcut on iOS, which is caused by a different UX on this platform. Committed: https://crrev.com/07e7e93ef4715bb5e803cc0151b82987b20530c3 Cr-Commit-Position: refs/heads/master@{#318864}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	components/translate/core/browser/translate_infobar_delegate.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972123002/1

5 years, 9 months ago (2015-03-03 10:36:26 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-03 12:12:49 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/07e7e93ef4715bb5e803cc0151b82987b20530c3
Cr-Commit-Position: refs/heads/master@{#318864}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages