Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 972093002: Re-enable app list browser test on experimental app list. (Closed)

Created:
5 years, 9 months ago by Matt Giuca
Modified:
5 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable app list browser test on experimental app list. AppListControllerSearchResultsBrowserTest.UninstallSearchResult is now run on the experimental app list, rather than being forced to run on the classic app list, as crbug.com/438119 is now fixed. BUG=438119 Committed: https://crrev.com/ea82a5686c5810a40d610ae6439e29d994fe9f35 Cr-Commit-Position: refs/heads/master@{#319203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
Hope this passes browsertests now...
5 years, 9 months ago (2015-03-03 06:26:31 UTC) #2
calamity
lgtm
5 years, 9 months ago (2015-03-05 01:40:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972093002/1
5 years, 9 months ago (2015-03-05 02:02:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 03:09:36 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 03:10:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea82a5686c5810a40d610ae6439e29d994fe9f35
Cr-Commit-Position: refs/heads/master@{#319203}

Powered by Google App Engine
This is Rietveld 408576698