Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: tests/language/async_this_bound_test.dart

Issue 972063003: Make sure to bind a method to its receiver if it is stored in a temporary. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Avoid using JavaScript bind. Rely on functions never changing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/async_this_bound_test.dart
diff --git a/tests/language/await_not_started_immediately_test.dart b/tests/language/async_this_bound_test.dart
similarity index 62%
copy from tests/language/await_not_started_immediately_test.dart
copy to tests/language/async_this_bound_test.dart
index 035885e09c23480054e0dcf5c31ff63ca3a35963..8efaa533335a37ea55566250cfb25328ba432442 100644
--- a/tests/language/await_not_started_immediately_test.dart
+++ b/tests/language/async_this_bound_test.dart
@@ -2,21 +2,22 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// Test that an async function does not start immediately.
-
import "package:expect/expect.dart";
import "package:async_helper/async_helper.dart";
-var x = 0;
+class A {
+ int a = -1;
floitsch 2015/03/06 16:32:16 Make it look like 'a' can be mutated. Otherwise we
sigurdm 2015/03/09 14:34:12 Done.
+ foo(ignored) {
+ (){};
floitsch 2015/03/06 16:32:16 Rather use "@NoInline" from Expect.
sigurdm 2015/03/09 14:34:12 Done.
+ Expect.equals(-1, a);
floitsch 2015/03/06 16:32:16 write "this.a" ?
sigurdm 2015/03/09 14:34:12 Done.
+ }
+}
-foo() async {
- x++;
- await 1;
- x++;
+test() async {
+ new A().foo(await false);
}
void main() {
asyncStart();
- foo().then((_) => Expect.equals(2, x)).whenComplete(asyncEnd);
- Expect.equals(0, x);
+ test().then((_) => asyncEnd());
floitsch 2015/03/06 16:32:16 dbc: maybe we should make asyncEnd take an optiona
sigurdm 2015/03/09 14:34:12 Acknowledged.
}

Powered by Google App Engine
This is Rietveld 408576698