Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Side by Side Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 972063003: Make sure to bind a method to its receiver if it is stored in a temporary. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Avoid using JavaScript bind. Rely on functions never changing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class SsaFunctionCompiler implements FunctionCompiler { 7 class SsaFunctionCompiler implements FunctionCompiler {
8 SsaCodeGeneratorTask generator; 8 SsaCodeGeneratorTask generator;
9 SsaBuilderTask builder; 9 SsaBuilderTask builder;
10 SsaOptimizerTask optimizer; 10 SsaOptimizerTask optimizer;
11 11
12 SsaFunctionCompiler(JavaScriptBackend backend, bool generateSourceMap) 12 SsaFunctionCompiler(JavaScriptBackend backend, bool generateSourceMap)
13 : generator = new SsaCodeGeneratorTask(backend), 13 : generator = new SsaCodeGeneratorTask(backend),
14 builder = new SsaBuilderTask(backend, generateSourceMap), 14 builder = new SsaBuilderTask(backend, generateSourceMap),
15 optimizer = new SsaOptimizerTask(backend); 15 optimizer = new SsaOptimizerTask(backend);
16 16
17 /// Generates JavaScript code for `work.element`. 17 /// Generates JavaScript code for `work.element`.
18 /// Using the ssa builder, optimizer and codegenerator. 18 /// Using the ssa builder, optimizer and codegenerator.
19 js.Fun compile(CodegenWorkItem work) { 19 js.Fun compile(CodegenWorkItem work) {
20 HGraph graph = builder.build(work); 20 HGraph graph = builder.build(work);
21 optimizer.optimize(work, graph); 21 optimizer.optimize(work, graph);
22 Element element = work.element; 22 Element element = work.element;
23 js.Expression result = generator.generateCode(work, graph); 23 js.Expression result = generator.generateCode(work, graph);
24 if (element is FunctionElement) { 24 if (element is FunctionElement) {
25 JavaScriptBackend backend = builder.backend; 25 JavaScriptBackend backend = builder.backend;
26 26
27 AsyncRewriterBase rewriter = null; 27 AsyncRewriterBase rewriter = null;
28 if (element.name.startsWith("foo")) print(js.prettyPrint(result, backend.c ompiler).getText());
floitsch 2015/03/06 16:32:16 debug print.
sigurdm 2015/03/09 14:34:12 Done.
28 29
29 if (element.asyncMarker == AsyncMarker.ASYNC) { 30 if (element.asyncMarker == AsyncMarker.ASYNC) {
30 rewriter = new AsyncRewriter( 31 rewriter = new AsyncRewriter(
31 backend.compiler, 32 backend.compiler,
32 backend.compiler.currentElement, 33 backend.compiler.currentElement,
33 asyncHelper: 34 asyncHelper:
34 backend.emitter.staticFunctionAccess(backend.getAsyncHelper()), 35 backend.emitter.staticFunctionAccess(backend.getAsyncHelper()),
35 newCompleter: backend.emitter.staticFunctionAccess( 36 newCompleter: backend.emitter.staticFunctionAccess(
36 backend.getCompleterConstructor()), 37 backend.getCompleterConstructor()),
37 safeVariableName: backend.namer.safeVariableName); 38 safeVariableName: backend.namer.safeVariableName);
(...skipping 22 matching lines...) Expand all
60 newController: backend.emitter.staticFunctionAccess( 61 newController: backend.emitter.staticFunctionAccess(
61 backend.getASyncStarControllerConstructor()), 62 backend.getASyncStarControllerConstructor()),
62 safeVariableName: backend.namer.safeVariableName, 63 safeVariableName: backend.namer.safeVariableName,
63 yieldExpression: backend.emitter.staticFunctionAccess( 64 yieldExpression: backend.emitter.staticFunctionAccess(
64 backend.getYieldSingle()), 65 backend.getYieldSingle()),
65 yieldStarExpression: backend.emitter.staticFunctionAccess( 66 yieldStarExpression: backend.emitter.staticFunctionAccess(
66 backend.getYieldStar())); 67 backend.getYieldStar()));
67 } 68 }
68 if (rewriter != null) { 69 if (rewriter != null) {
69 result = rewriter.rewrite(result); 70 result = rewriter.rewrite(result);
71 if (element.name.startsWith("foo")) print(js.prettyPrint(result, backend .compiler).getText());
floitsch 2015/03/06 16:32:16 ditto.
sigurdm 2015/03/09 14:34:12 Done.
70 } 72 }
71 } 73 }
72 return result; 74 return result;
73 } 75 }
74 76
75 Iterable<CompilerTask> get tasks { 77 Iterable<CompilerTask> get tasks {
76 return <CompilerTask>[builder, optimizer, generator]; 78 return <CompilerTask>[builder, optimizer, generator];
77 } 79 }
78 } 80 }
79 81
(...skipping 6857 matching lines...) Expand 10 before | Expand all | Expand 10 after
6937 if (unaliased is TypedefType) throw 'unable to unalias $type'; 6939 if (unaliased is TypedefType) throw 'unable to unalias $type';
6938 unaliased.accept(this, builder); 6940 unaliased.accept(this, builder);
6939 } 6941 }
6940 6942
6941 void visitDynamicType(DynamicType type, SsaBuilder builder) { 6943 void visitDynamicType(DynamicType type, SsaBuilder builder) {
6942 JavaScriptBackend backend = builder.compiler.backend; 6944 JavaScriptBackend backend = builder.compiler.backend;
6943 ClassElement cls = backend.findHelper('DynamicRuntimeType'); 6945 ClassElement cls = backend.findHelper('DynamicRuntimeType');
6944 builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld))); 6946 builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
6945 } 6947 }
6946 } 6948 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698