Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 972053002: [x64] Use movaps instead of movsd for the move between double registers. (Closed)

Created:
5 years, 9 months ago by Weiliang
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Use movaps instead of movsd for the move between double registers. Committed: https://crrev.com/11d97bf531676392fee2cb66eaf0b15f8d423e3d Cr-Commit-Position: refs/heads/master@{#26950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Weiliang
PTAL
5 years, 9 months ago (2015-03-03 05:50:41 UTC) #2
Benedikt Meurer
A few years ago I did a similar patch for OCaml (http://caml.inria.fr/mantis/view.php?id=5180), but using movapd, ...
5 years, 9 months ago (2015-03-03 05:54:34 UTC) #3
Weiliang
On 2015/03/03 05:54:34, Benedikt Meurer wrote: > A few years ago I did a similar ...
5 years, 9 months ago (2015-03-03 06:12:55 UTC) #4
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-03 06:13:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972053002/1
5 years, 9 months ago (2015-03-03 06:15:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 06:34:19 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 06:34:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d97bf531676392fee2cb66eaf0b15f8d423e3d
Cr-Commit-Position: refs/heads/master@{#26950}

Powered by Google App Engine
This is Rietveld 408576698