[WebView] Add test for visual state API when view dettached.

[WebView] Add test for visual state API when view dettached.

Calling the visual state API when the container view is dettached
must draw the contents correctly when the callback is received.
We add a test for that.

We also fix a possible crash if the container view is dettached
after insertVisualStateCallback has been called but before
the callback has been received.

Original author igsolla@chromium.org
BUG=461369, 457184
Committed: https://crrev.com/c196c218d8d9cc726c2c57077f81313f555233a3
Cr-Commit-Position: refs/heads/master@{#319112}

[boliu, 2015-03-04 01:00:17]

boliu@chromium.org changed reviewers:
+ tobiasjs@chromium.org

[boliu, 2015-03-04 01:00:18]

ptal

[Tobias Sargeant, 2015-03-04 17:25:12]

lgtm

[boliu, 2015-03-04 17:26:21]

boliu@chromium.org changed reviewers:
+ hush@chromium.org

[boliu, 2015-03-04 17:26:21]

+hush for committer stamp

[hush (inactive), 2015-03-04 18:39:09]

https://codereview.chromium.org/972013003/diff/40001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/972013003/diff/40001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2222:
mHandler.post(new Runnable() {
what's the difference between mContainerView.getHandler() and mHandler?
Assuming AwContents constructor is always called on the UI loop. Then
They are both UI thread handlers, why not just use the former?

https://codereview.chromium.org/972013003/diff/40001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
(right):

https://codereview.chromium.org/972013003/diff/40001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java:336:
final AtomicReference<AwContents> awContentsRef = new AtomicReference<>();
Why not "AtomicReference<AwContents>" on the right?
The comment for the next line.

[boliu, 2015-03-04 19:16:44]

https://codereview.chromium.org/972013003/diff/40001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/972013003/diff/40001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2222:
mHandler.post(new Runnable() {
On 2015/03/04 18:39:08, hush wrote:
> what's the difference between mContainerView.getHandler() and mHandler?
> Assuming AwContents constructor is always called on the UI loop. Then
> They are both UI thread handlers, why not just use the former?

mHandler is one we create. mContainerView.getHandler() returns null when the
view is detached

https://codereview.chromium.org/972013003/diff/40001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
(right):

https://codereview.chromium.org/972013003/diff/40001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java:336:
final AtomicReference<AwContents> awContentsRef = new AtomicReference<>();
On 2015/03/04 18:39:08, hush wrote:
> Why not "AtomicReference<AwContents>" on the right?
> The comment for the next line.

http://docs.oracle.com/javase/7/docs/technotes/guides/language/type-inference...

[hush (inactive), 2015-03-04 19:39:54]

The CQ bit was checked by hush@chromium.org

[hush (inactive), 2015-03-04 19:39:54]

lgtm

https://codereview.chromium.org/972013003/diff/40001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/972013003/diff/40001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2222:
mHandler.post(new Runnable() {
On 2015/03/04 19:16:43, boliu wrote:
> On 2015/03/04 18:39:08, hush wrote:
> > what's the difference between mContainerView.getHandler() and mHandler?
> > Assuming AwContents constructor is always called on the UI loop. Then
> > They are both UI thread handlers, why not just use the former?
> 
> mHandler is one we create. mContainerView.getHandler() returns null when the
> view is detached

OK.

https://codereview.chromium.org/972013003/diff/40001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
(right):

https://codereview.chromium.org/972013003/diff/40001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java:336:
final AtomicReference<AwContents> awContentsRef = new AtomicReference<>();
On 2015/03/04 19:16:43, boliu wrote:
> On 2015/03/04 18:39:08, hush wrote:
> > Why not "AtomicReference<AwContents>" on the right?
> > The comment for the next line.
> 
>
http://docs.oracle.com/javase/7/docs/technotes/guides/language/type-inference...

Okay.

[commit-bot: I haz the power, 2015-03-04 19:41:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/972013003/40001

[commit-bot: I haz the power, 2015-03-04 20:05:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-04 20:06:23]

Patchset 3 (id:??) landed as
https://crrev.com/c196c218d8d9cc726c2c57077f81313f555233a3
Cr-Commit-Position: refs/heads/master@{#319112}