Linux/Gtk: Setting last_mouse_down_ to NULL on focus-out of the render widget for context menu popu…

Linux/Gtk: Setting last_mouse_down_ to NULL on focus-out of the render widget for context menu to popup for GDK_CURRENT_TIME.

BUG=84899
TEST=As described in the bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128565

[SanjoyPal, 2012-03-19 07:47:50]

PTAL. Thanks

[Jói, 2012-03-20 10:29:11]

lgtm

I'm not a suitable reviewer to determine whether this is the right thing to do
(I don't know GTK).  Removing myself from the reviewer's list.

(Assuming this is the right way to do it:  Nice fix!)

Cheers,
Jói

[Jói, 2012-03-20 10:29:46]

Doh, didn't mean to LGTM, pressed the wrong button in the code review tool. 
Please get an LGTM from one of the remaining reviewers.

Cheers,
Jói


> I'm not a suitable reviewer to determine whether this is the right thing to do
> (I don't know GTK).  Removing myself from the reviewer's list.
> 
> (Assuming this is the right way to do it:  Nice fix!)
> 
> Cheers,
> Jói

[Elliot Glaysher, 2012-03-20 17:25:55]

The BUG= number is wrong and leads to a duped win bug. I'm not sure what you're
trying to fix.

[SanjoyPal, 2012-03-21 05:34:55]

On 2012/03/20 17:25:55, Elliot Glaysher wrote:
> The BUG= number is wrong and leads to a duped win bug. I'm not sure what
you're
> trying to fix.

Updated the BUG=Number.

[yzshen1, 2012-03-21 17:12:50]

I am not a suitable reviewer for linux/gtk, either. I will leave this CL to
Elliot. (Thanks, Elliot!)


On 2012/03/21 05:34:55, SanjoyPal wrote:
> On 2012/03/20 17:25:55, Elliot Glaysher wrote:
> > The BUG= number is wrong and leads to a duped win bug. I'm not sure what
> you're
> > trying to fix.
> 
> Updated the BUG=Number.

[Elliot Glaysher, 2012-03-21 17:19:02]

lgtm

[commit-bot: I haz the power, 2012-03-21 17:19:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/9720037/1

[commit-bot: I haz the power, 2012-03-21 17:19:18]

Presubmit check for 9720037-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[SanjoyPal, 2012-03-23 05:29:10]

On 2012/03/21 17:19:18, I haz the power (commit-bot) wrote:
> Presubmit check for 9720037-1 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for files in these directories:
>     content/browser
> 
> Was the presubmit check useful? Please send feedback & hate mail to
> maruel@chromium.org!

OWNERs, PTAL. Thanks

[Avi (use Gerrit), 2012-03-23 14:47:55]

If Elliot likes it, who am I to say no? LGTM

[commit-bot: I haz the power, 2012-03-23 17:26:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/9720037/1

[commit-bot: I haz the power, 2012-03-23 20:06:41]

Change committed as 128565