Chromium Code Reviews
Help | Chromium Project | Sign in
(985)

Issue 9720037: Linux/Gtk: Setting last_mouse_down_ to NULL on focus-out of the render widget for context menu popu… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by SanjoyPal
Modified:
2 years ago
CC:
chromium-reviews_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Linux/Gtk: Setting last_mouse_down_ to NULL on focus-out of the render widget for context menu to popup for GDK_CURRENT_TIME.

BUG=84899
TEST=As described in the bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Lint Patch
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 13
SanjoyPal
PTAL. Thanks
2 years, 1 month ago #1
Jói
lgtm I'm not a suitable reviewer to determine whether this is the right thing to ...
2 years, 1 month ago #2
Jói
Doh, didn't mean to LGTM, pressed the wrong button in the code review tool. Please ...
2 years, 1 month ago #3
Elliot Glaysher
The BUG= number is wrong and leads to a duped win bug. I'm not sure ...
2 years, 1 month ago #4
SanjoyPal
On 2012/03/20 17:25:55, Elliot Glaysher wrote: > The BUG= number is wrong and leads to ...
2 years, 1 month ago #5
yzshen1 (OOO until Apr 21)
I am not a suitable reviewer for linux/gtk, either. I will leave this CL to ...
2 years, 1 month ago #6
Elliot Glaysher
lgtm
2 years, 1 month ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/9720037/1
2 years, 1 month ago #8
I haz the power (commit-bot)
Presubmit check for 9720037-1 failed and returned exit status 1. Running presubmit commit checks ...
2 years, 1 month ago #9
SanjoyPal
On 2012/03/21 17:19:18, I haz the power (commit-bot) wrote: > Presubmit check for 9720037-1 failed ...
2 years ago #10
Avi
If Elliot likes it, who am I to say no? LGTM
2 years ago #11
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/9720037/1
2 years ago #12
I haz the power (commit-bot)
2 years ago #13
Change committed as 128565
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6