extensions: reinstate trash focus/closing logic after switch to

extensions: reinstate trash focus/closing logic after switch to
chrome.management.uninstall.

R=rdevlin.cronin@chromium.org
BUG=463003
Committed: https://crrev.com/ead446a77684e0b9e6bca3de187dcc1544104e3e
Cr-Commit-Position: refs/heads/master@{#318825}

[Devlin, 2015-03-03 00:17:40]

lgtm.

Sorry for missing that, Dan.

https://codereview.chromium.org/971993002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/971993002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extension_list.js:471: if
(chrome.extension.lastError)
Maybe a comment like:
// chrome.extension.lastError is set if the uninstall failed or was canceled;
// in either case, the entry in the list is still present.
?

[Dan Beam, 2015-03-03 00:25:43]

On 2015/03/03 00:17:40, Devlin wrote:
> lgtm.
> 
> Sorry for missing that, Dan.

it's all good; I added this approximately 3s before you changed
chrome://extensions from chrome.send() -> chrome.management.* (and probably
caused merge conflicts that were hard to resolve).

https://codereview.chromium.org/971993002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/971993002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extension_list.js:471: if
(chrome.extension.lastError)
On 2015/03/03 00:17:40, Devlin wrote:
> Maybe a comment like:
> // chrome.extension.lastError is set if the uninstall failed or was canceled;
> // in either case, the entry in the list is still present.
> ?

Added comment to that effect.

[Dan Beam, 2015-03-03 00:28:04]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-03-03 00:28:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/971993002/#ps20001 (title:
"comment")

[commit-bot: I haz the power, 2015-03-03 00:29:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971993002/20001

[commit-bot: I haz the power, 2015-03-03 01:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-03 01:03:44]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2015-03-03 01:10:41]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-03-03 01:12:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971993002/20001

[commit-bot: I haz the power, 2015-03-03 03:13:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-03 03:14:18]

Patchset 2 (id:??) landed as
https://crrev.com/ead446a77684e0b9e6bca3de187dcc1544104e3e
Cr-Commit-Position: refs/heads/master@{#318825}