Issue 971973002: Add Windows icu data dll for ICU 54

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971973002: Add Windows icu data dll for ICU 54 (Closed)

Created:
5 years, 9 months ago by jungshik at Google

Modified:
5 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add Windows icu data dll for ICU 54 V8 does still use the icu data dll. Build icudt.dll on Windows with the latest icudtl.dat. Follow-up to https://codereview.chromium.org/962643003/ BUG=428145 TEST=With icu_data_file_flag=0 in GYP_DEFINES, run 'gclient runhooks' and build base_unittests. Run it with '--gtest_filter=*Conv*' R=jochen@chromium.org TBR=jochen@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/eda9e75b1fa17f57ffa369ee3543a2301b68d0a9

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	M	windows/icudt.dll	View		Binary file		0 comments	Download

Total messages: 4 (1 generated)

jungshik at Google

5 years, 9 months ago (2015-03-03 17:53:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eda9e75b1fa17f57ffa369ee3543a2301b68d0a9 (presubmit successful).