Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 971943002: Avoid repeat call to set number of worker threads in Single Process (Closed)

Created:
5 years, 9 months ago by weiliangc
Modified:
5 years, 9 months ago
Reviewers:
enne (OOO), piman
CC:
chromium-reviews, danakj, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman, reveman, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid repeat call to set number of worker threads in Single Process In single process mode with impl-side-painting, browser and renderer would both try to set number of raster worker threads, which causes DCHECK. This CL makes sure there won't be duplicate call to set number of worker threads in single process mode. R=enne BUG=314185 Committed: https://crrev.com/67c3b8b09ef08fcbc2f22c75c39b68f1df9610b9 Cr-Commit-Position: refs/heads/master@{#318995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
weiliangc
5 years, 9 months ago (2015-03-02 22:36:22 UTC) #1
enne (OOO)
lgtm, but I'm not an owner.
5 years, 9 months ago (2015-03-02 22:45:49 UTC) #2
weiliangc
piman@?
5 years, 9 months ago (2015-03-02 22:54:20 UTC) #4
piman
lgtm
5 years, 9 months ago (2015-03-04 00:38:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971943002/1
5 years, 9 months ago (2015-03-04 00:56:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 02:02:20 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 02:03:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67c3b8b09ef08fcbc2f22c75c39b68f1df9610b9
Cr-Commit-Position: refs/heads/master@{#318995}

Powered by Google App Engine
This is Rietveld 408576698