Issue 9719003: Compute preorder as well as postorder basic block orderings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9719003: Compute preorder as well as postorder basic block orderings. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Compute preorder as well as postorder basic block orderings. The Lengauer-Tarjan dominator/dominance frontier algorithm needs to visit the blocks in reverse preorder (in the first pass) and preorder (in the second). Compute that at the same time as postorder (e.g., using the same spanning tree). Take this chance to make the flow graph visitors always operate on a forward block ordering. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5598

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -134 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	6 chunks	+27 lines, -20 lines	2 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	6 chunks	+21 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	23 chunks	+63 lines, -41 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+60 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/9719003/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): http://codereview.chromium.org/9719003/diff/1/runtime/vm/flow_graph_builder.cc#newcode1332 runtime/vm/flow_graph_builder.cc:1332: const GrowableArray<BlockEntryInstr*>& block_order) remove explicit.

8 years, 9 months ago (2012-03-16 22:01:17 UTC) #2

Kevin Millikin (Google)

8 years, 9 months ago (2012-03-16 22:18:31 UTC) #3

http://codereview.chromium.org/9719003/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

http://codereview.chromium.org/9719003/diff/1/runtime/vm/flow_graph_builder.c...
runtime/vm/flow_graph_builder.cc:1332: const GrowableArray<BlockEntryInstr*>&
block_order)
On 2012/03/16 22:01:17, srdjan wrote:
> remove explicit. 

Thanks.

Expand Messages | Collapse Messages