runtime/lib/compact_hash.dart - Issue 971833002: Correct typing of LinkedHashSet.add. Add unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/compact_hash.dart

Issue 971833002: Correct typing of LinkedHashSet.add. Add unit test. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/compact_hash.dart

===================================================================

--- runtime/lib/compact_hash.dart (revision 44128)

+++ runtime/lib/compact_hash.dart (working copy)

@@ -337,7 +337,7 @@

// Set implementation, analogous to _CompactLinkedHashMap.

class _CompactLinkedHashSet<K>

extends SetBase<K> with _HashBase

- implements HashSet<K>, LinkedHashSet<K> {

+ implements LinkedHashSet<K> {

_CompactLinkedHashSet() {

assert(_HashBase._UNUSED_PAIR == 0);

@@ -377,7 +377,7 @@

}

- bool add(Object key) {

+ bool add(K key) {

final int size = _index.length;

final int sizeMask = size - 1;

final int maxEntries = size >> 1;

« no previous file with comments | « no previous file | tests/corelib/hash_set_type_check_test.dart » ('j') | no next file with comments »