Issue 971823002: rename `as` helper to make tools happy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971823002: rename `as` helper to make tools happy (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly

Modified:
5 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

rename `as` helper to make tools happy WebStorm ES6 support treats `as` as a keyword. Not sure why, as I don't see it in any ES6 specs, even under "future reserved words". R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/41d88b5345f854dfce436cb45c18380a2f08f154

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	lib/runtime/dart_runtime.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 9 months ago (2015-03-02 19:03:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41d88b5345f854dfce436cb45c18380a2f08f154 (presubmit successful).