Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 971813002: Add a callback from Blink to Chromium for when page scale changes (Closed)

Created:
5 years, 9 months ago by ccameron
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a callback from Blink to Chromium for when page scale changes This is to allow command-zero to reset page scale (in particular, to allow Chromium to know when command-zero will have any effect). BUG=456880 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebViewClient.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ccameron (do not use)
dcheng, can you take a look at this -- this is the Blink component of ...
5 years, 9 months ago (2015-03-03 18:52:39 UTC) #2
dcheng
lgtm Note that long-term, the plan in content (due to the out-of-process iframes work) is ...
5 years, 9 months ago (2015-03-03 20:04:10 UTC) #3
ccameron
Thanks! Interesting -- is there a doc for the proposed changes that I can take ...
5 years, 9 months ago (2015-03-03 20:24:56 UTC) #4
dcheng
On 2015/03/03 at 20:24:56, ccameron wrote: > Thanks! > > Interesting -- is there a ...
5 years, 9 months ago (2015-03-03 20:28:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971813002/1
5 years, 9 months ago (2015-03-03 20:31:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191241
5 years, 9 months ago (2015-03-04 05:01:11 UTC) #8
Charlie Reis
5 years, 9 months ago (2015-03-04 22:55:14 UTC) #9
Message was sent while issue was closed.
On 2015/03/03 20:28:57, dcheng wrote:
> On 2015/03/03 at 20:24:56, ccameron wrote:
> > Thanks!
> > 
> > Interesting -- is there a doc for the proposed changes that I can take a
look
> at?
> 
> There's a bunch of information at the bottom of
> http://www.chromium.org/developers/design-documents/site-isolation in the
"Site
> Isolation Summit 2015" section. The slides will probably be the most helpful
for
> a quick overview.
> 
> jam@ also posted a PSA about RenderView and RenderViewHost here:
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/9qTMXFyPN_g
> 
> (I've CCed creis@ who might be able to link in more documents that I've
missed)

Yes, those are the right places to look.  In particular, the Feature Update FAQ
for OOPIF covers it:
https://docs.google.com/document/d/1Iqe_CzFVA6hyxe7h2bUKusxsjB6frXfdAYLerM3Jj...

Thanks!

Powered by Google App Engine
This is Rietveld 408576698