treat backwards quads as not convex

treat backwards quads as not convex

If a quad, cubic, or conic goes back on itself, assume it's not convex.
In a future CL, we could check to see if the curve is linear so that
linear curves are treated the same as lines.

BUG=skia:3469
Committed: https://skia.googlesource.com/skia/+/5ccef577902ce1aefa05fb8107ad5d0aba848e7d

[caryclark, 2015-03-02 16:42:27]

caryclark@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-03-02 17:18:45]

lgtm + nits

https://codereview.chromium.org/971773002/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/971773002/diff/1/src/core/SkPath.cpp#newcode2267
src/core/SkPath.cpp:2267: pts[1] = pts[0];
// fall through ?

https://codereview.chromium.org/971773002/diff/1/src/core/SkPath.cpp#newcode2271
src/core/SkPath.cpp:2271: break;
// fall throughs ?

[caryclark, 2015-03-02 17:55:57]

https://codereview.chromium.org/971773002/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/971773002/diff/1/src/core/SkPath.cpp#newcode2267
src/core/SkPath.cpp:2267: pts[1] = pts[0];
On 2015/03/02 17:18:44, robertphillips wrote:
> // fall through ?

Done.

https://codereview.chromium.org/971773002/diff/1/src/core/SkPath.cpp#newcode2271
src/core/SkPath.cpp:2271: break;
On 2015/03/02 17:18:45, robertphillips wrote:
> // fall throughs ?

Done.

[caryclark, 2015-03-02 17:56:04]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-03-02 17:56:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/971773002/#ps20001 (title:
"add fall through comments")

[commit-bot: I haz the power, 2015-03-02 17:56:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971773002/20001

[commit-bot: I haz the power, 2015-03-02 18:07:59]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5ccef577902ce1aefa05fb8107ad5d0aba848e7d