Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc

Issue 971733003: Supervised users: When an extension requires new permissions, send request to custodian (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_ext_install_disable
Patch Set: test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
diff --git a/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc b/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
index a4402e82872d399e4727ccd6cc93c5193f960fd4..0bba1cee1790a06e106c36936bd8aa7e8d529a0c 100644
--- a/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
+++ b/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
@@ -13,10 +13,10 @@
#include "net/base/escape.h"
#include "url/gurl.h"
-using base::Time;
-
const char kSupervisedUserAccessRequestKeyPrefix[] =
"X-ManagedUser-AccessRequests";
+const char kSupervisedUserUpdateRequestKeyPrefix[] =
+ "X-ManagedUser-UpdateRequests";
const char kSupervisedUserAccessRequestTime[] = "timestamp";
const char kSupervisedUserName[] = "name";
@@ -48,20 +48,33 @@ bool PermissionRequestCreatorSync::IsEnabled() const {
state == GoogleServiceAuthError::SERVICE_UNAVAILABLE);
}
-void PermissionRequestCreatorSync::CreatePermissionRequest(
+void PermissionRequestCreatorSync::CreateURLAccessRequest(
const GURL& url_requested,
const SuccessCallback& callback) {
- // Escape the URL and add the prefix.
+ CreateRequest(kSupervisedUserAccessRequestKeyPrefix,
+ url_requested.spec(),
+ callback);
+}
+
+void PermissionRequestCreatorSync::CreateExtensionUpdateRequest(
+ const std::string& extension_id,
+ const SuccessCallback& callback) {
+ CreateRequest(kSupervisedUserUpdateRequestKeyPrefix, extension_id, callback);
+}
+
+void PermissionRequestCreatorSync::CreateRequest(
+ const std::string& prefix,
+ const std::string& data,
+ const SuccessCallback& callback) {
+ // Escape the data string and add the prefix.
std::string key = SupervisedUserSettingsService::MakeSplitSettingKey(
- kSupervisedUserAccessRequestKeyPrefix,
- net::EscapeQueryParamValue(url_requested.spec(), true));
+ prefix,
+ net::EscapeQueryParamValue(data, true));
scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
-
// TODO(sergiu): Use sane time here when it's ready.
dict->SetDouble(kSupervisedUserAccessRequestTime,
base::Time::Now().ToJsTime());
-
dict->SetString(kSupervisedUserName, name_);
// Copy the notification setting of the custodian.

Powered by Google App Engine
This is Rietveld 408576698