Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7112)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 971733003: Supervised users: When an extension requires new permissions, send request to custodian (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_ext_install_disable
Patch Set: test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 3b0a8b33e911c545be6a377cdd3063476e287e94..a3ad60be63708f76c8f86a7f2706d3b05ffaa86a 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -134,6 +134,7 @@
#include "url/gurl.h"
#if defined(ENABLE_SUPERVISED_USERS)
+#include "chrome/browser/supervised_user/permission_request_creator.h"
#include "chrome/browser/supervised_user/supervised_user_service.h"
#include "chrome/browser/supervised_user/supervised_user_service_factory.h"
#endif
@@ -6609,6 +6610,26 @@ TEST_F(ExtensionServiceTest, ProcessSyncDataNotInstalled) {
}
#if defined(ENABLE_SUPERVISED_USERS)
+class MockPermissionRequestCreator : public PermissionRequestCreator {
+ public:
+ MockPermissionRequestCreator() {}
+ ~MockPermissionRequestCreator() override {}
+
+ bool IsEnabled() const override { return true; }
+
+ void CreateURLAccessRequest(const GURL& url_requested,
+ const SuccessCallback& callback) override {
+ FAIL();
+ }
+
+ MOCK_METHOD2(CreateExtensionUpdateRequest,
+ void(const std::string& extension_id,
+ const SupervisedUserService::SuccessCallback& callback));
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MockPermissionRequestCreator);
+};
+
TEST_F(ExtensionServiceTest, SupervisedUser_InstallOnlyAllowedByCustodian) {
ExtensionServiceInitParams params = CreateDefaultInitParams();
params.profile_is_supervised = true;
@@ -6676,6 +6697,9 @@ TEST_F(ExtensionServiceTest, SupervisedUser_UpdateWithPermissionIncrease) {
SupervisedUserService* supervised_user_service =
SupervisedUserServiceFactory::GetForProfile(profile());
GetManagementPolicy()->RegisterProvider(supervised_user_service);
+ MockPermissionRequestCreator* creator = new MockPermissionRequestCreator;
+ supervised_user_service->AddPermissionRequestCreator(
+ make_scoped_ptr(creator));
base::FilePath base_path = data_dir().AppendASCII("permissions_increase");
base::FilePath pem_path = base_path.AppendASCII("permissions.pem");
@@ -6694,6 +6718,7 @@ TEST_F(ExtensionServiceTest, SupervisedUser_UpdateWithPermissionIncrease) {
std::string old_version = extension->VersionString();
// Update to a new version with increased permissions.
+ EXPECT_CALL(*creator, CreateExtensionUpdateRequest(id, testing::_));
path = base_path.AppendASCII("v2");
PackCRXAndUpdateExtension(id, path, pem_path, DISABLED);

Powered by Google App Engine
This is Rietveld 408576698