Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 971733002: Don't use staging GAIA if --gaia-url was explicitly specified in command line (Closed)

Created:
5 years, 9 months ago by Dmitry Polukhin
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use staging GAIA if --gaia-url was explicitly specified in command line BUG=461854 TEST=manual Committed: https://crrev.com/54a734e8a147cb86eb3675b97a30ff9b41f45545 Cr-Commit-Position: refs/heads/master@{#318693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Polukhin
5 years, 9 months ago (2015-03-02 13:16:02 UTC) #2
Nikita (slow)
lgtm
5 years, 9 months ago (2015-03-02 13:23:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971733002/1
5 years, 9 months ago (2015-03-02 14:33:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 15:10:37 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 15:11:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54a734e8a147cb86eb3675b97a30ff9b41f45545
Cr-Commit-Position: refs/heads/master@{#318693}

Powered by Google App Engine
This is Rietveld 408576698