Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: ash/shelf/shelf_view.cc

Issue 97173003: ash: Rename more Launcher classes to Shelf*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: similarity 30 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_view.cc
diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc
index 9393368234bcab52ff121368cb4622c4cf6ef7f4..7a97003361a3d6d1a266f91a570bb4d218c5d82b 100644
--- a/ash/shelf/shelf_view.cc
+++ b/ash/shelf/shelf_view.cc
@@ -10,8 +10,6 @@
#include "ash/ash_switches.h"
#include "ash/drag_drop/drag_image_view.h"
#include "ash/launcher/launcher_delegate.h"
-#include "ash/launcher/launcher_item_delegate.h"
-#include "ash/launcher/launcher_item_delegate_manager.h"
#include "ash/root_window_controller.h"
#include "ash/scoped_target_root_window.h"
#include "ash/shelf/alternate_app_list_button.h"
@@ -21,6 +19,8 @@
#include "ash/shelf/overflow_button.h"
#include "ash/shelf/shelf_button.h"
#include "ash/shelf/shelf_icon_observer.h"
+#include "ash/shelf/shelf_item_delegate.h"
+#include "ash/shelf/shelf_item_delegate_manager.h"
#include "ash/shelf/shelf_layout_manager.h"
#include "ash/shelf/shelf_model.h"
#include "ash/shelf/shelf_tooltip_manager.h"
@@ -393,7 +393,7 @@ ShelfView::ShelfView(ShelfModel* model,
drag_and_drop_launcher_id_(0),
dragged_off_shelf_(false),
snap_back_from_rip_off_view_(NULL),
- item_manager_(Shell::GetInstance()->launcher_item_delegate_manager()),
+ item_manager_(Shell::GetInstance()->shelf_item_delegate_manager()),
layout_manager_(shelf_layout_manager),
overflow_mode_(false) {
DCHECK(model_);
@@ -979,7 +979,7 @@ void ShelfView::PrepareForDrag(Pointer pointer, const ui::LocatedEvent& event) {
}
// If the item is no longer draggable, bail out.
- LauncherItemDelegate* item_delegate = item_manager_->GetLauncherItemDelegate(
+ ShelfItemDelegate* item_delegate = item_manager_->GetShelfItemDelegate(
model_->items()[start_drag_index_].id);
if (!item_delegate->IsDraggable()) {
CancelDrag(-1);
@@ -997,7 +997,7 @@ void ShelfView::ContinueDrag(const ui::LocatedEvent& event) {
int current_index = view_model_->GetIndexOfView(drag_view_);
DCHECK_NE(-1, current_index);
- LauncherItemDelegate* item_delegate = item_manager_->GetLauncherItemDelegate(
+ ShelfItemDelegate* item_delegate = item_manager_->GetShelfItemDelegate(
model_->items()[current_index].id);
if (!item_delegate->IsDraggable()) {
CancelDrag(-1);
@@ -1614,7 +1614,7 @@ void ShelfView::PointerPressedOnButton(views::View* view,
if (index == -1)
return;
- LauncherItemDelegate* item_delegate = item_manager_->GetLauncherItemDelegate(
+ ShelfItemDelegate* item_delegate = item_manager_->GetShelfItemDelegate(
model_->items()[index].id);
if (view_model_->view_size() <= 1 || !item_delegate->IsDraggable())
return; // View is being deleted or not draggable, ignore request.
@@ -1690,7 +1690,7 @@ base::string16 ShelfView::GetAccessibleName(const views::View* view) {
if (view_index == -1)
return base::string16();
- LauncherItemDelegate* item_delegate = item_manager_->GetLauncherItemDelegate(
+ ShelfItemDelegate* item_delegate = item_manager_->GetShelfItemDelegate(
model_->items()[view_index].id);
return item_delegate->GetTitle();
}
@@ -1748,9 +1748,8 @@ void ShelfView::ButtonPressed(views::Button* sender, const ui::Event& event) {
break;
}
- LauncherItemDelegate* item_delegate =
- item_manager_->GetLauncherItemDelegate(
- model_->items()[view_index].id);
+ ShelfItemDelegate* item_delegate =
+ item_manager_->GetShelfItemDelegate(model_->items()[view_index].id);
if (!item_delegate->ItemSelected(event))
ShowListMenuForView(model_->items()[view_index], sender, event);
}
@@ -1759,9 +1758,9 @@ void ShelfView::ButtonPressed(views::Button* sender, const ui::Event& event) {
bool ShelfView::ShowListMenuForView(const LauncherItem& item,
views::View* source,
const ui::Event& event) {
- scoped_ptr<ash::LauncherMenuModel> menu_model;
- LauncherItemDelegate* item_delegate =
- item_manager_->GetLauncherItemDelegate(item.id);
+ scoped_ptr<LauncherMenuModel> menu_model;
+ ShelfItemDelegate* item_delegate =
+ item_manager_->GetShelfItemDelegate(item.id);
menu_model.reset(item_delegate->CreateApplicationMenu(event.flags()));
// Make sure we have a menu and it has at least two items in addition to the
@@ -1783,9 +1782,8 @@ void ShelfView::ShowContextMenuForView(views::View* source,
ui::MenuSourceType source_type) {
int view_index = view_model_->GetIndexOfView(source);
// TODO(simon.hong81): Create LauncherContextMenu for applist in its
- // LauncherItemDelegate.
- if (view_index != -1 &&
- model_->items()[view_index].type == TYPE_APP_LIST) {
+ // ShelfItemDelegate.
+ if (view_index != -1 && model_->items()[view_index].type == TYPE_APP_LIST) {
view_index = -1;
}
@@ -1794,7 +1792,7 @@ void ShelfView::ShowContextMenuForView(views::View* source,
return;
}
scoped_ptr<ui::MenuModel> menu_model;
- LauncherItemDelegate* item_delegate = item_manager_->GetLauncherItemDelegate(
+ ShelfItemDelegate* item_delegate = item_manager_->GetShelfItemDelegate(
model_->items()[view_index].id);
menu_model.reset(item_delegate->CreateContextMenu(
source->GetWidget()->GetNativeView()->GetRootWindow()));
@@ -1955,8 +1953,8 @@ bool ShelfView::ShouldShowTooltipForView(const views::View* view) const {
const LauncherItem* item = LauncherItemForView(view);
if (!item)
return true;
- LauncherItemDelegate* item_delegate =
- item_manager_->GetLauncherItemDelegate(item->id);
+ ShelfItemDelegate* item_delegate =
+ item_manager_->GetShelfItemDelegate(item->id);
return item_delegate->ShouldShowTooltip();
}

Powered by Google App Engine
This is Rietveld 408576698