ash: Rename more Launcher classes to Shelf*.

ash: Rename more Launcher classes to Shelf*.

* Rename LauncherItemDelegate to ShelfItemDelegate.
* Move launcher_item_delegate.h from launcher/ to shelf/
* Rename to shelf_item_delegate.h

* Rename TestLauncherItemDelegate to TestShelfItemDelegate.
* Move test_launcher_item_delegate.* from launcher/ to shelf/
* Rename to test_shelf_item_delegate.*

* Rename LauncherItemDelegateManager to ShelfItemDelegateManager.
* Move launcher_item_delegate_manager.* from launcher/ to shelf/
* Rename to shelf_item_delegate_manager.*

* Rename LauncherItemDelegateManagerTestAPI to ShelfItemDelegateManagerTestAPI.
* Move launcher_item_delegate_manager_test_api.* from launcher/ to shelf/
* Rename to shelf_item_delegate_manager_test_api.*

* Rename WindowWatcherLauncherItemDelegate to WindowWatcherShelfItemDelegate.
* Move window_watcher_launcher_item_delegate.* from launcher/ to shelf/
* Rename to window_watcher_shelf_item_delegate.*

* Rename LauncherMenuModel to ShelfMenuModel.
* Host it into its own header file named shelf_menu_model.h

BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238696

[Harry McCleave, 2013-12-02 18:35:53]

One quick question brought on by multiple class definitions in same header.

Also this patch creates some interesting comments which I assume will be
addressed in an upcoming refactor; eg ShelfItemDelegate is the delegate for the
LauncherItem.

other than that lgtm.

https://codereview.chromium.org/97173003/diff/19/chrome/browser/ui/ash/launch...
File chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h
(right):

https://codereview.chromium.org/97173003/diff/19/chrome/browser/ui/ash/launch...
chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h:9:
#include "ash/shelf/shelf_item_delegate.h"
Should this patch also refactor LauncherMenuModel to ShelfMenuModel (and/or
split to separate file)?

[tfarina, 2013-12-02 18:41:31]

https://codereview.chromium.org/97173003/diff/19/ash/shelf/shelf_item_delegate.h
File ash/shelf/shelf_item_delegate.h (right):

https://codereview.chromium.org/97173003/diff/19/ash/shelf/shelf_item_delegat...
ash/shelf/shelf_item_delegate.h:19: class ASH_EXPORT LauncherMenuModel : public
ui::SimpleMenuModel {
Glad you noticed it. I'm two mind, but I think I can do this in this patch as
well.

I'll split this in its own header file: shelf_menu_model.h

[tfarina, 2013-12-03 23:36:24]

I made the changes.

James, could you review (rubber stamp) this to me?

Thank you both!

[James Cook, 2013-12-03 23:44:24]

On 2013/12/03 23:36:24, tfarina wrote:
> I made the changes.
> 
> James, could you review (rubber stamp) this to me?
> 
> Thank you both!

I don't see shelf_menu_model.h - did the upload miss it?

[tfarina, 2013-12-04 00:24:02]

On 2013/12/03 23:44:24, James Cook wrote:
> I don't see shelf_menu_model.h - did the upload miss it?
Ops, I forgot to git add it. Done (plus compile fixes).

[James Cook, 2013-12-04 00:50:55]

LGTM. Thanks again for working on this massive rename.

[commit-bot: I haz the power, 2013-12-04 12:10:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/97173003/220001

[commit-bot: I haz the power, 2013-12-04 13:52:50]

Change committed as 238696