Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 971723002: Files.app: Rename FileSystemMetadata with MetadataModel. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Rename FileSystemMetadata with MetadataModel. BUG=410766 TEST=None Committed: https://crrev.com/3e6c51585d6523900b08889692f995f6138500da Cr-Commit-Position: refs/heads/master@{#318834}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -1045 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_jstest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/audio_player/audio_player.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player_scripts.js View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/dialog_action_controller.js View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 8 chunks +16 lines, -16 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 5 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 10 chunks +18 lines, -18 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_selection.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 1 chunk +2 lines, -1 line 0 comments Download
D ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata.js View 1 chunk +0 lines, -188 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.js View 1 chunk +1 line, -2 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_unittest.html View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_unittest.js View 1 chunk +0 lines, -145 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js View 1 2 8 chunks +22 lines, -45 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html View 1 chunk +2 lines, -1 line 0 comments Download
A + ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.js View 1 2 3 chunks +47 lines, -47 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider.js View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js View 1 chunk +0 lines, -224 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.html View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js View 1 chunk +0 lines, -172 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata_update_controller.js View 5 chunks +8 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/task_controller.js View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/task_controller_unittest.js View 6 chunks +7 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 4 chunks +12 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 9 chunks +12 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 7 chunks +10 lines, -10 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/gallery/gallery.html View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_data_model.js View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_data_model_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-02 12:14:37 UTC) #2
mtomasz
https://codereview.chromium.org/971723002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js (right): https://codereview.chromium.org/971723002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js#newcode46 ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js:46: MetadataModel.prototype.getRawProvider = function() { nit: Maybe just getProvider? https://codereview.chromium.org/971723002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider.js ...
5 years, 9 months ago (2015-03-03 01:58:01 UTC) #3
hirono
Thanks! https://codereview.chromium.org/971723002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js (right): https://codereview.chromium.org/971723002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js#newcode46 ui/file_manager/file_manager/foreground/js/metadata/metadata_model.js:46: MetadataModel.prototype.getRawProvider = function() { On 2015/03/03 01:58:01, mtomasz ...
5 years, 9 months ago (2015-03-03 02:28:34 UTC) #4
mtomasz
lgtm!
5 years, 9 months ago (2015-03-03 02:31:50 UTC) #5
hirono
On 2015/03/03 02:31:50, mtomasz wrote: > lgtm! Thanks!
5 years, 9 months ago (2015-03-03 03:11:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971723002/40001
5 years, 9 months ago (2015-03-03 03:11:44 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 03:33:26 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 03:34:08 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3e6c51585d6523900b08889692f995f6138500da
Cr-Commit-Position: refs/heads/master@{#318834}

Powered by Google App Engine
This is Rietveld 408576698