Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 971703002: DevTools: fix co-existance of multiple DevTools extensions (Closed)

Created:
5 years, 9 months ago by caseq
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix co-existance of multiple DevTools extensions We stopped passing injectedScriptId that was used to generate unique ids for extension objects by ExtensionAPI.js after https://codereview.chromium.org/900543003 so multiple extensions could not co-exist. BUG=460065 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191093

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -5 lines) Patch
M LayoutTests/http/tests/inspector/resources/extension-main.js View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/inspector/extensions/multiple-extensions.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/inspector/extensions/multiple-extensions-expected.txt View 1 1 chunk +43 lines, -0 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionAPI.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caseq
5 years, 9 months ago (2015-03-02 09:19:35 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-02 09:38:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971703002/20001
5 years, 9 months ago (2015-03-02 09:40:58 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 10:55:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191093

Powered by Google App Engine
This is Rietveld 408576698