Issue 971693002: convert object::* to return maybe values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971693002: convert object::* to return maybe values (Closed)

Created:
5 years, 9 months ago by dcarney

Modified:
5 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

convert object::* to return maybe values BUG=v8:3929 LOG=y R=svenpanne@chromium.org Committed: https://crrev.com/1fcedda6689c88acc055ddfc43441d58f2f99ce2 Cr-Commit-Position: refs/heads/master@{#26940}

Patch Set 8 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+368 lines, -231 lines)			Patch
M	include/v8.h	View	1 2 3 4 5 6 7	5 chunks	+43 lines, -10 lines	0 comments	Download
M	src/api.cc	View	1 2 3 4 5 6 7	22 chunks	+307 lines, -209 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 2 3 4 5 6 7	2 chunks	+18 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sven Panne

lgtm https://codereview.chromium.org/971693002/diff/120001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/971693002/diff/120001/include/v8.h#newcode457 include/v8.h:457: if (val_ == nullptr) return default_value; Ternary aversion? ...

5 years, 9 months ago (2015-03-02 12:37:12 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 13:13:42 UTC) #3

Message was sent while issue was closed.

Patchset 8 (id:??) landed as
https://crrev.com/1fcedda6689c88acc055ddfc43441d58f2f99ce2
Cr-Commit-Position: refs/heads/master@{#26940}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 971693002: convert object::* to return maybe values (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : rebase #

Patch Set 8 : #

Messages