Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 971673005: For consistency, use our homebrew zlib everywhere possible. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org, hal.canary
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

For consistency, use our homebrew zlib everywhere possible. This switches when we build our own zlib from "just Windows" to "everyone, but not Android framework of course". I tested this by building DM for my Mac and for an Android bot config. It took minor tweaks to the GYP to get ARM builds working. BUG=skia: Committed: https://skia.googlesource.com/skia/+/5a8f2257b0b0f954fb74f65e7ea3ada772ed9240 CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug-Trybot,Test-ChromeOS-Alex-GMA3150-x86-Release-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot

Patch Set 1 #

Patch Set 2 : no -Werror, depend on pthread #

Patch Set 3 : all deps #

Patch Set 4 : try linux only #

Patch Set 5 : flail #

Patch Set 6 : fix up linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M gyp/zlib.gyp View 1 2 3 4 5 3 chunks +33 lines, -29 lines 0 comments Download

Messages

Total messages: 53 (29 generated)
mtklein_C
5 years, 9 months ago (2015-03-02 18:29:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/1
5 years, 9 months ago (2015-03-02 18:29:52 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-02 18:29:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/2394)
5 years, 9 months ago (2015-03-02 18:30:54 UTC) #7
mtklein
Well, of course it fails on Ubuntu because I happened not to test there locally...
5 years, 9 months ago (2015-03-02 18:39:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/1
5 years, 9 months ago (2015-03-04 15:11:16 UTC) #11
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-04 15:11:16 UTC) #12
scroggo
lgtm
5 years, 9 months ago (2015-03-04 15:12:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/2411) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 9 months ago (2015-03-04 15:12:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/20001
5 years, 9 months ago (2015-03-04 15:19:26 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/2413)
5 years, 9 months ago (2015-03-04 15:20:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/40001
5 years, 9 months ago (2015-03-04 15:41:46 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2808)
5 years, 9 months ago (2015-03-04 15:45:29 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/60001
5 years, 9 months ago (2015-03-04 15:53:56 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/2418)
5 years, 9 months ago (2015-03-04 15:55:07 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/80001
5 years, 9 months ago (2015-03-04 16:52:27 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/2423)
5 years, 9 months ago (2015-03-04 16:53:57 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/100001
5 years, 9 months ago (2015-03-06 16:20:09 UTC) #40
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/5a8f2257b0b0f954fb74f65e7ea3ada772ed9240
5 years, 9 months ago (2015-03-07 00:15:19 UTC) #41
mtklein
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/989873002/ by mtklein@google.com. ...
5 years, 9 months ago (2015-03-07 15:47:32 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/100001
5 years, 9 months ago (2015-03-08 14:35:36 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot/builds/111)
5 years, 9 months ago (2015-03-08 14:39:46 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971673005/140001
5 years, 9 months ago (2015-03-08 15:48:26 UTC) #49
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 15:50:26 UTC) #51
Try jobs failed on following builders:
  Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX66...)

Powered by Google App Engine
This is Rietveld 408576698